s390/qdio: remove always-true condition
authorJulian Wiedmann <jwi@linux.ibm.com>
Tue, 21 Apr 2020 15:20:00 +0000 (17:20 +0200)
committerVasily Gorbik <gor@linux.ibm.com>
Tue, 28 Apr 2020 11:49:48 +0000 (13:49 +0200)
buf_in_between() gets passed q->u.in.ack_start as 'bufnr' parameter.

The ack_start always ranges between 0 and QDIO_MAX_BUFFERS_PER_Q - 1,
so the subsequent check will always return true. Remove it.

Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Reviewed-by: Benjamin Block <bblock@linux.ibm.com>
Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
drivers/s390/cio/qdio_main.c

index 68985871b6bf8cfb3befc8adb6fa9cb89b858e97..4bd6dbfe8387059d8ff93902784c5420b573ab7e 100644 (file)
@@ -1450,8 +1450,7 @@ static inline int buf_in_between(int bufnr, int start, int count)
        }
 
        /* wrap-around case */
-       if ((bufnr >= start && bufnr <= QDIO_MAX_BUFFERS_PER_Q) ||
-           (bufnr < end))
+       if (bufnr >= start || bufnr < end)
                return 1;
        else
                return 0;