media: gspca: make array regs_to_read static const
authorColin Ian King <colin.i.king@gmail.com>
Sun, 9 Jan 2022 20:45:57 +0000 (21:45 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Sun, 23 Jan 2022 20:18:43 +0000 (21:18 +0100)
Don't populate the read-only array regs_to_read on the stack but
instead it static const. Also makes the object code a little smaller.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/usb/gspca/jl2005bcd.c

index ca12f33f3e12cac92ee093492807659c1340d4ff..a408fcc3a0608f7a3f5e235c96076cd553cb6535 100644 (file)
@@ -166,7 +166,9 @@ static int jl2005c_get_firmware_id(struct gspca_dev *gspca_dev)
        struct sd *sd = (struct sd *)gspca_dev;
        int i = 0;
        int retval;
-       unsigned char regs_to_read[] = {0x57, 0x02, 0x03, 0x5d, 0x5e, 0x5f};
+       static const unsigned char regs_to_read[] = {
+               0x57, 0x02, 0x03, 0x5d, 0x5e, 0x5f
+       };
 
        gspca_dbg(gspca_dev, D_PROBE, "Running jl2005c_get_firmware_id\n");
        /* Read the first ID byte once for warmup */