workqueue: wq_watchdog_touch is always called with valid CPU
authorNicholas Piggin <npiggin@gmail.com>
Tue, 25 Jun 2024 11:42:44 +0000 (21:42 +1000)
committerTejun Heo <tj@kernel.org>
Tue, 25 Jun 2024 16:55:16 +0000 (06:55 -1000)
Warn in the case it is called with cpu == -1. This does not appear
to happen anywhere.

Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
Reviewed-by: Paul E. McKenney <paulmck@kernel.org>
Signed-off-by: Tejun Heo <tj@kernel.org>
kernel/workqueue.c

index adf1893b161ee5d8a01e3a98a19595a38b0a02c0..b032772bd144609c3f6b510d310e7627fc5d1ca6 100644 (file)
@@ -7526,6 +7526,8 @@ notrace void wq_watchdog_touch(int cpu)
 {
        if (cpu >= 0)
                per_cpu(wq_watchdog_touched_cpu, cpu) = jiffies;
+       else
+               WARN_ONCE(1, "%s should be called with valid CPU", __func__);
 
        wq_watchdog_touched = jiffies;
 }