media: v4l2-subdev: Drop unreacheable warning
authorLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Mon, 13 Nov 2023 09:35:23 +0000 (11:35 +0200)
committerLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Wed, 19 Jun 2024 16:43:11 +0000 (19:43 +0300)
The v4l2_subdev_link_validate_get_format() function warns if the pad
given as argument belongs to a non-subdev entity. This can't happen, as
the function is called from v4l2_subdev_link_validate() only (indirectly
through v4l2_subdev_link_validate_locked()), and that function ensures
that both ends of the link are subdevs.

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
drivers/media/v4l2-core/v4l2-subdev.c

index 4f71199bf5920dbc702e6bcc0ab822e245e1a5cb..7c5812d5531512c349cd57b7114f65f2f1d6e339 100644 (file)
@@ -1269,14 +1269,6 @@ v4l2_subdev_link_validate_get_format(struct media_pad *pad, u32 stream,
        struct v4l2_subdev *sd;
        int ret;
 
-       if (!is_media_entity_v4l2_subdev(pad->entity)) {
-               WARN(pad->entity->function != MEDIA_ENT_F_IO_V4L,
-                    "Driver bug! Wrong media entity type 0x%08x, entity %s\n",
-                    pad->entity->function, pad->entity->name);
-
-               return -EINVAL;
-       }
-
        sd = media_entity_to_v4l2_subdev(pad->entity);
 
        fmt->which = V4L2_SUBDEV_FORMAT_ACTIVE;