bnxt_en: implement dump callback for fw health reporter

Populate the dump with firmware 'live' coredump data. This includes
the information stored in NVRAM by the firmware exception handler
prior to recovery. Thus, the live dump includes the desired crash
context.

Firmware does not support HWRM calls after RESET_NOTIFY, so there is
no supported way to capture a coredump during the auto dump phase.
Detect this and abort when called from devlink_health_report().

Signed-off-by: Edwin Peer <edwin.peer@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
index 930cbf1ca4e02ab3e7c36783b365b0fc8e65e466..106f4249e47b2b81158f62fea931dbf9828f4b07 100644 (file)
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
@@ -18,6 +18,7 @@
 #include "bnxt_ethtool.h"
 #include "bnxt_ulp.h"
 #include "bnxt_ptp.h"
+#include "bnxt_coredump.h"
 
 static void __bnxt_fw_recover(struct bnxt *bp)
 {
@@ -177,6 +178,46 @@ unlock:
        return devlink_fmsg_u32_pair_put(fmsg, "Diagnoses", h->diagnoses);
 }
 
+static int bnxt_fw_dump(struct devlink_health_reporter *reporter,
+                       struct devlink_fmsg *fmsg, void *priv_ctx,
+                       struct netlink_ext_ack *extack)
+{
+       struct bnxt *bp = devlink_health_reporter_priv(reporter);
+       u32 dump_len;
+       void *data;
+       int rc;
+
+       /* TODO: no firmware dump support in devlink_health_report() context */
+       if (priv_ctx)
+               return -EOPNOTSUPP;
+
+       dump_len = bnxt_get_coredump_length(bp, BNXT_DUMP_LIVE);
+       if (!dump_len)
+               return -EIO;
+
+       data = vmalloc(dump_len);
+       if (!data)
+               return -ENOMEM;
+
+       rc = bnxt_get_coredump(bp, BNXT_DUMP_LIVE, data, &dump_len);
+       if (!rc) {
+               rc = devlink_fmsg_pair_nest_start(fmsg, "core");
+               if (rc)
+                       goto exit;
+               rc = devlink_fmsg_binary_pair_put(fmsg, "data", data, dump_len);
+               if (rc)
+                       goto exit;
+               rc = devlink_fmsg_u32_pair_put(fmsg, "size", dump_len);
+               if (rc)
+                       goto exit;
+               rc = devlink_fmsg_pair_nest_end(fmsg);
+       }
+
+exit:
+       vfree(data);
+       return rc;
+}
+
 static int bnxt_fw_recover(struct devlink_health_reporter *reporter,
                           void *priv_ctx,
                           struct netlink_ext_ack *extack)
@@ -195,6 +236,7 @@ static int bnxt_fw_recover(struct devlink_health_reporter *reporter,
 static const struct devlink_health_reporter_ops bnxt_dl_fw_reporter_ops = {
        .name = "fw",
        .diagnose = bnxt_fw_diagnose,
+       .dump = bnxt_fw_dump,
        .recover = bnxt_fw_recover,
 };