Input: mouse - use sysfs_emit[_at]() instead of scnprintf()

Replace the calls to various *printf() functions with sysfs_emit() to
simplify the code.

Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
Link: https://lore.kernel.org/r/202212021453578171100@zte.com.cn
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

diff --git a/drivers/input/mouse/cyapa.c b/drivers/input/mouse/cyapa.c
index a84098448f5b94d607dc5b86ceb5f04618783179..5979deabe23d192f47debae819d1ddc488d8edc6 100644 (file)
--- a/drivers/input/mouse/cyapa.c
+++ b/drivers/input/mouse/cyapa.c
@@ -756,16 +756,16 @@ static ssize_t cyapa_show_suspend_scanrate(struct device *dev,
 
        switch (pwr_cmd) {
        case PWR_MODE_BTN_ONLY:
-               len = scnprintf(buf, PAGE_SIZE, "%s\n", BTN_ONLY_MODE_NAME);
+               len = sysfs_emit(buf, "%s\n", BTN_ONLY_MODE_NAME);
                break;
 
        case PWR_MODE_OFF:
-               len = scnprintf(buf, PAGE_SIZE, "%s\n", OFF_MODE_NAME);
+               len = sysfs_emit(buf, "%s\n", OFF_MODE_NAME);
                break;
 
        default:
-               len = scnprintf(buf, PAGE_SIZE, "%u\n",
-                               cyapa->gen == CYAPA_GEN3 ?
+               len = sysfs_emit(buf, "%u\n",
+                                cyapa->gen == CYAPA_GEN3 ?
                                        cyapa_pwr_cmd_to_sleep_time(pwr_cmd) :
                                        sleep_time);
                break;
@@ -877,8 +877,8 @@ static ssize_t cyapa_show_rt_suspend_scanrate(struct device *dev,
 
        mutex_unlock(&cyapa->state_sync_lock);
 
-       return scnprintf(buf, PAGE_SIZE, "%u\n",
-                        cyapa->gen == CYAPA_GEN3 ?
+       return sysfs_emit(buf, "%u\n",
+                         cyapa->gen == CYAPA_GEN3 ?
                                cyapa_pwr_cmd_to_sleep_time(pwr_cmd) :
                                sleep_time);
 }
@@ -988,8 +988,8 @@ static ssize_t cyapa_show_fm_ver(struct device *dev,
        error = mutex_lock_interruptible(&cyapa->state_sync_lock);
        if (error)
                return error;
-       error = scnprintf(buf, PAGE_SIZE, "%d.%d\n", cyapa->fw_maj_ver,
-                        cyapa->fw_min_ver);
+       error = sysfs_emit(buf, "%d.%d\n",
+                          cyapa->fw_maj_ver, cyapa->fw_min_ver);
        mutex_unlock(&cyapa->state_sync_lock);
        return error;
 }
@@ -1004,7 +1004,7 @@ static ssize_t cyapa_show_product_id(struct device *dev,
        error = mutex_lock_interruptible(&cyapa->state_sync_lock);
        if (error)
                return error;
-       size = scnprintf(buf, PAGE_SIZE, "%s\n", cyapa->product_id);
+       size = sysfs_emit(buf, "%s\n", cyapa->product_id);
        mutex_unlock(&cyapa->state_sync_lock);
        return size;
 }
@@ -1209,8 +1209,8 @@ static ssize_t cyapa_show_mode(struct device *dev,
        if (error)
                return error;
 
-       size = scnprintf(buf, PAGE_SIZE, "gen%d %s\n",
-                       cyapa->gen, cyapa_state_to_string(cyapa));
+       size = sysfs_emit(buf, "gen%d %s\n",
+                         cyapa->gen, cyapa_state_to_string(cyapa));
 
        mutex_unlock(&cyapa->state_sync_lock);
        return size;

diff --git a/drivers/input/mouse/cyapa_gen3.c b/drivers/input/mouse/cyapa_gen3.c
index a97f4acb64526248178715e035b89dd9a93eef37..60c83bc71d84e662d15af2654c54ba2cb39e4147 100644 (file)
--- a/drivers/input/mouse/cyapa_gen3.c
+++ b/drivers/input/mouse/cyapa_gen3.c
@@ -860,7 +860,7 @@ static ssize_t cyapa_gen3_show_baseline(struct device *dev,
 
        dev_dbg(dev, "Baseline report successful. Max: %d Min: %d\n",
                max_baseline, min_baseline);
-       ret = scnprintf(buf, PAGE_SIZE, "%d %d\n", max_baseline, min_baseline);
+       ret = sysfs_emit(buf, "%d %d\n", max_baseline, min_baseline);
 
 out:
        return ret;

diff --git a/drivers/input/mouse/cyapa_gen5.c b/drivers/input/mouse/cyapa_gen5.c
index abf42f77b4c593d1b3f8406832d2a67684780b8d..2e6bcb07257ed7374ac69e288d21fc4133cddb85 100644 (file)
--- a/drivers/input/mouse/cyapa_gen5.c
+++ b/drivers/input/mouse/cyapa_gen5.c
@@ -2418,12 +2418,12 @@ resume_scanning:
                return resume_error ? resume_error : error;
 
        /* 12. Output data strings */
-       size = scnprintf(buf, PAGE_SIZE, "%d %d %d %d %d %d %d %d %d %d %d ",
+       size = sysfs_emit(buf, "%d %d %d %d %d %d %d %d %d %d %d ",
                gidac_mutual_min, gidac_mutual_max, gidac_mutual_ave,
                lidac_mutual_min, lidac_mutual_max, lidac_mutual_ave,
                gidac_self_rx, gidac_self_tx,
                lidac_self_min, lidac_self_max, lidac_self_ave);
-       size += scnprintf(buf + size, PAGE_SIZE - size,
+       size += sysfs_emit_at(buf, size,
                "%d %d %d %d %d %d %d %d %d %d %d %d %d %d %d %d %d %d\n",
                raw_cap_mutual_min, raw_cap_mutual_max, raw_cap_mutual_ave,
                raw_cap_self_min, raw_cap_self_max, raw_cap_self_ave,

diff --git a/drivers/input/mouse/cyapa_gen6.c b/drivers/input/mouse/cyapa_gen6.c
index 0caaf3e64215d00c57196967f229d7892afe8acc..4ffe08fee10c8a465cb3e4042de08b335ffa6f0b 100644 (file)
--- a/drivers/input/mouse/cyapa_gen6.c
+++ b/drivers/input/mouse/cyapa_gen6.c
@@ -629,14 +629,14 @@ static ssize_t cyapa_gen6_show_baseline(struct device *dev,
        if (error)
                goto resume_scanning;
 
-       size = scnprintf(buf, PAGE_SIZE, "%d %d %d %d %d %d ",
-                       data[0],  /* RX Attenuator Mutual */
-                       data[1],  /* IDAC Mutual */
-                       data[2],  /* RX Attenuator Self RX */
-                       data[3],  /* IDAC Self RX */
-                       data[4],  /* RX Attenuator Self TX */
-                       data[5]   /* IDAC Self TX */
-                       );
+       size = sysfs_emit(buf, "%d %d %d %d %d %d ",
+                         data[0],  /* RX Attenuator Mutual */
+                         data[1],  /* IDAC Mutual */
+                         data[2],  /* RX Attenuator Self RX */
+                         data[3],  /* IDAC Self RX */
+                         data[4],  /* RX Attenuator Self TX */
+                         data[5]   /* IDAC Self TX */
+                        );
 
        /* 3. Read Attenuator Trim. */
        data_len = sizeof(data);
@@ -648,8 +648,8 @@ static ssize_t cyapa_gen6_show_baseline(struct device *dev,
 
        /* set attenuator trim values. */
        for (i = 0; i < data_len; i++)
-               size += scnprintf(buf + size, PAGE_SIZE - size, "%d ", data[i]);
-       size += scnprintf(buf + size, PAGE_SIZE - size, "\n");
+               size += sysfs_emit_at(buf, size, "%d ", data[i]);
+       size += sysfs_emit_at(buf, size, "\n");
 
 resume_scanning:
        /* 4. Resume Scanning*/

diff --git a/drivers/input/mouse/elan_i2c_core.c b/drivers/input/mouse/elan_i2c_core.c
index 148a601396f92cd5293405fe0355f57672154e4e..8a72c200ccb5d127d1dcd209b8eda29f4b619fef 100644 (file)
--- a/drivers/input/mouse/elan_i2c_core.c
+++ b/drivers/input/mouse/elan_i2c_core.c
@@ -572,7 +572,7 @@ static ssize_t elan_sysfs_read_fw_checksum(struct device *dev,
        struct i2c_client *client = to_i2c_client(dev);
        struct elan_tp_data *data = i2c_get_clientdata(client);
 
-       return sprintf(buf, "0x%04x\n", data->fw_checksum);
+       return sysfs_emit(buf, "0x%04x\n", data->fw_checksum);
 }
 
 static ssize_t elan_sysfs_read_product_id(struct device *dev,
@@ -582,8 +582,8 @@ static ssize_t elan_sysfs_read_product_id(struct device *dev,
        struct i2c_client *client = to_i2c_client(dev);
        struct elan_tp_data *data = i2c_get_clientdata(client);
 
-       return sprintf(buf, ETP_PRODUCT_ID_FORMAT_STRING "\n",
-                      data->product_id);
+       return sysfs_emit(buf, ETP_PRODUCT_ID_FORMAT_STRING "\n",
+                         data->product_id);
 }
 
 static ssize_t elan_sysfs_read_fw_ver(struct device *dev,
@@ -593,7 +593,7 @@ static ssize_t elan_sysfs_read_fw_ver(struct device *dev,
        struct i2c_client *client = to_i2c_client(dev);
        struct elan_tp_data *data = i2c_get_clientdata(client);
 
-       return sprintf(buf, "%d.0\n", data->fw_version);
+       return sysfs_emit(buf, "%d.0\n", data->fw_version);
 }
 
 static ssize_t elan_sysfs_read_sm_ver(struct device *dev,
@@ -603,7 +603,7 @@ static ssize_t elan_sysfs_read_sm_ver(struct device *dev,
        struct i2c_client *client = to_i2c_client(dev);
        struct elan_tp_data *data = i2c_get_clientdata(client);
 
-       return sprintf(buf, "%d.0\n", data->sm_version);
+       return sysfs_emit(buf, "%d.0\n", data->sm_version);
 }
 
 static ssize_t elan_sysfs_read_iap_ver(struct device *dev,
@@ -613,7 +613,7 @@ static ssize_t elan_sysfs_read_iap_ver(struct device *dev,
        struct i2c_client *client = to_i2c_client(dev);
        struct elan_tp_data *data = i2c_get_clientdata(client);
 
-       return sprintf(buf, "%d.0\n", data->iap_version);
+       return sysfs_emit(buf, "%d.0\n", data->iap_version);
 }
 
 static ssize_t elan_sysfs_update_fw(struct device *dev,
@@ -754,7 +754,7 @@ static ssize_t elan_sysfs_read_mode(struct device *dev,
        if (error)
                return error;
 
-       return sprintf(buf, "%d\n", (int)mode);
+       return sysfs_emit(buf, "%d\n", (int)mode);
 }
 
 static DEVICE_ATTR(product_id, S_IRUGO, elan_sysfs_read_product_id, NULL);
@@ -858,7 +858,7 @@ static ssize_t min_show(struct device *dev,
                goto out;
        }
 
-       retval = snprintf(buf, PAGE_SIZE, "%d", data->min_baseline);
+       retval = sysfs_emit(buf, "%d", data->min_baseline);
 
 out:
        mutex_unlock(&data->sysfs_mutex);
@@ -881,7 +881,7 @@ static ssize_t max_show(struct device *dev,
                goto out;
        }
 
-       retval = snprintf(buf, PAGE_SIZE, "%d", data->max_baseline);
+       retval = sysfs_emit(buf, "%d", data->max_baseline);
 
 out:
        mutex_unlock(&data->sysfs_mutex);