net: vrf: correct FRA_L3MDEV encode type
authorJeff Barnhill <0xeffeff@gmail.com>
Wed, 1 Nov 2017 14:58:09 +0000 (14:58 +0000)
committerDavid S. Miller <davem@davemloft.net>
Thu, 2 Nov 2017 07:20:53 +0000 (16:20 +0900)
FRA_L3MDEV is defined as U8, but is being added as a U32 attribute. On
big endian architecture, this results in the l3mdev entry not being
added to the FIB rules.

Fixes: 1aa6c4f6b8cd8 ("net: vrf: Add l3mdev rules on first device create")
Signed-off-by: Jeff Barnhill <0xeffeff@gmail.com>
Acked-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/vrf.c

index 9b243e6f3008bb5319844412cd49db1cd7bce594..7dc3bcac350666396cf943fdcb583e0d97c6bf8e 100644 (file)
@@ -1165,7 +1165,7 @@ static int vrf_fib_rule(const struct net_device *dev, __u8 family, bool add_it)
        frh->family = family;
        frh->action = FR_ACT_TO_TBL;
 
-       if (nla_put_u32(skb, FRA_L3MDEV, 1))
+       if (nla_put_u8(skb, FRA_L3MDEV, 1))
                goto nla_put_failure;
 
        if (nla_put_u32(skb, FRA_PRIORITY, FIB_RULE_PREF))