projects
/
linux-block.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
96111f1
)
net: ibm: emac: tah: use devm for mutex_init
author
Rosen Penev
<rosenp@gmail.com>
Wed, 30 Oct 2024 20:37:17 +0000
(13:37 -0700)
committer
Jakub Kicinski
<kuba@kernel.org>
Sun, 3 Nov 2024 22:37:42 +0000
(14:37 -0800)
It seems that since inception, this driver never called mutex_destroy in
_remove. Use devm to handle this automatically.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Link:
https://patch.msgid.link/20241030203727.6039-3-rosenp@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/ibm/emac/tah.c
patch
|
blob
|
blame
|
history
diff --git
a/drivers/net/ethernet/ibm/emac/tah.c
b/drivers/net/ethernet/ibm/emac/tah.c
index 267c23ec15d7171978a20b69cb3cfc2bcc076c25..4b325505053b733f4fc648849af368acd34f5f7c 100644
(file)
--- a/
drivers/net/ethernet/ibm/emac/tah.c
+++ b/
drivers/net/ethernet/ibm/emac/tah.c
@@
-90,13
+90,17
@@
static int tah_probe(struct platform_device *ofdev)
struct device_node *np = ofdev->dev.of_node;
struct tah_instance *dev;
struct resource regs;
+ int err;
dev = devm_kzalloc(&ofdev->dev, sizeof(struct tah_instance),
GFP_KERNEL);
if (!dev)
return -ENOMEM;
- mutex_init(&dev->lock);
+ err = devm_mutex_init(&ofdev->dev, &dev->lock);
+ if (err)
+ return err;
+
dev->ofdev = ofdev;
if (of_address_to_resource(np, 0, ®s)) {