ALSA: pci: Remove superfluous snd_pcm_suspend*() calls
authorTakashi Iwai <tiwai@suse.de>
Fri, 11 Jan 2019 17:02:51 +0000 (18:02 +0100)
committerTakashi Iwai <tiwai@suse.de>
Tue, 15 Jan 2019 16:47:15 +0000 (17:47 +0100)
The call of snd_pcm_suspend_all() & co became superfluous since we
call it in the PCM PM ops.  Let's remove them.

Reviewed-by: Jaroslav Kysela <perex@perex.cz>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
32 files changed:
sound/pci/ali5451/ali5451.c
sound/pci/als300.c
sound/pci/als4000.c
sound/pci/atiixp_modem.c
sound/pci/azt3328.c
sound/pci/ca0106/ca0106_main.c
sound/pci/cmipci.c
sound/pci/cs4281.c
sound/pci/cs46xx/cs46xx_lib.c
sound/pci/cs5535audio/cs5535audio_pm.c
sound/pci/ctxfi/ctatc.c
sound/pci/echoaudio/echoaudio.c
sound/pci/emu10k1/emu10k1.c
sound/pci/ens1370.c
sound/pci/es1938.c
sound/pci/es1968.c
sound/pci/fm801.c
sound/pci/hda/hda_codec.c
sound/pci/ice1712/ice1712.c
sound/pci/ice1712/ice1724.c
sound/pci/intel8x0.c
sound/pci/intel8x0m.c
sound/pci/maestro3.c
sound/pci/nm256/nm256.c
sound/pci/oxygen/oxygen_lib.c
sound/pci/riptide/riptide.c
sound/pci/rme96.c
sound/pci/sis7019.c
sound/pci/trident/trident_main.c
sound/pci/via82xx.c
sound/pci/via82xx_modem.c
sound/pci/ymfpci/ymfpci_main.c

index 9f569379b77ed40f72247dc80bb8d81327ccb285..e781ccca17932815aeb6e6415fc3d073c5055466 100644 (file)
@@ -1882,10 +1882,8 @@ static int ali_suspend(struct device *dev)
                return 0;
 
        snd_power_change_state(card, SNDRV_CTL_POWER_D3hot);
-       for (i = 0; i < chip->num_of_codecs; i++) {
-               snd_pcm_suspend_all(chip->pcm[i]);
+       for (i = 0; i < chip->num_of_codecs; i++)
                snd_ac97_suspend(chip->ac97[i]);
-       }
 
        spin_lock_irq(&chip->reg_lock);
        
index eaa2d853d9223cdbb5f288002b28c291501dbe93..516b3d9cbfdfd9eadd5c8b6e2303ca5298af8070 100644 (file)
@@ -731,7 +731,6 @@ static int snd_als300_suspend(struct device *dev)
        struct snd_als300 *chip = card->private_data;
 
        snd_power_change_state(card, SNDRV_CTL_POWER_D3hot);
-       snd_pcm_suspend_all(chip->pcm);
        snd_ac97_suspend(chip->ac97);
        return 0;
 }
index 26b097edec8c90f55686dea0001925a257dfe333..45fa38382e79e9b00e2073925745722501229b72 100644 (file)
@@ -994,7 +994,6 @@ static int snd_als4000_suspend(struct device *dev)
 
        snd_power_change_state(card, SNDRV_CTL_POWER_D3hot);
        
-       snd_pcm_suspend_all(chip->pcm);
        snd_sbmixer_suspend(chip);
        return 0;
 }
index dc1de860cedf287d0ea991b9a181adeb9cebafa1..a357a8e2e73d7b0be92ec85409aa0e889b4e1a89 100644 (file)
@@ -1125,8 +1125,6 @@ static int snd_atiixp_suspend(struct device *dev)
        int i;
 
        snd_power_change_state(card, SNDRV_CTL_POWER_D3hot);
-       for (i = 0; i < NUM_ATI_PCMDEVS; i++)
-               snd_pcm_suspend_all(chip->pcmdevs[i]);
        for (i = 0; i < NUM_ATI_CODECS; i++)
                snd_ac97_suspend(chip->ac97[i]);
        snd_atiixp_aclink_down(chip);
index fc18c29a817302256da1dda0aa7d8feeaf2c2104..90348817f0969f65ff7037f7ea532fea9cf66432 100644 (file)
@@ -2699,10 +2699,6 @@ snd_azf3328_suspend(struct device *dev)
 
        snd_power_change_state(card, SNDRV_CTL_POWER_D3hot);
 
-       /* same pcm object for playback/capture */
-       snd_pcm_suspend_all(chip->pcm[AZF_CODEC_PLAYBACK]);
-       snd_pcm_suspend_all(chip->pcm[AZF_CODEC_I2S_OUT]);
-
        snd_azf3328_suspend_ac97(chip);
 
        snd_azf3328_suspend_regs(chip, chip->ctrl_io,
index cd27b5536654431643a108dd04887f1f76696a65..3d1b0bbff33b2e020793cb926903ec6ae7d37cf7 100644 (file)
@@ -1910,11 +1910,8 @@ static int snd_ca0106_suspend(struct device *dev)
 {
        struct snd_card *card = dev_get_drvdata(dev);
        struct snd_ca0106 *chip = card->private_data;
-       int i;
 
        snd_power_change_state(card, SNDRV_CTL_POWER_D3hot);
-       for (i = 0; i < 4; i++)
-               snd_pcm_suspend_all(chip->pcm[i]);
        if (chip->details->ac97)
                snd_ac97_suspend(chip->ac97);
        snd_ca0106_mixer_suspend(chip);
index 452cc79b44af3f1dbd77efcf07e92099f770ea70..5bbf31c1695c2863ee39842aa51a53db55892f22 100644 (file)
@@ -3351,10 +3351,6 @@ static int snd_cmipci_suspend(struct device *dev)
 
        snd_power_change_state(card, SNDRV_CTL_POWER_D3hot);
        
-       snd_pcm_suspend_all(cm->pcm);
-       snd_pcm_suspend_all(cm->pcm2);
-       snd_pcm_suspend_all(cm->pcm_spdif);
-
        /* save registers */
        for (i = 0; i < ARRAY_SIZE(saved_regs); i++)
                cm->saved_regs[i] = snd_cmipci_read(cm, saved_regs[i]);
index ec4247638fa14a6748de8c949cd553846bada13d..a9fb819cad1d46accac39ea931f4eb005b54a2a4 100644 (file)
@@ -2002,8 +2002,6 @@ static int cs4281_suspend(struct device *dev)
        unsigned int i;
 
        snd_power_change_state(card, SNDRV_CTL_POWER_D3hot);
-       snd_pcm_suspend_all(chip->pcm);
-
        snd_ac97_suspend(chip->ac97);
        snd_ac97_suspend(chip->ac97_secondary);
 
index 750eec437a795757d109e8ced727f2df36910777..a77d4cc44028a9f0c5d42c67c2e2ed2899b87051 100644 (file)
@@ -3781,12 +3781,6 @@ static int snd_cs46xx_suspend(struct device *dev)
 
        snd_power_change_state(card, SNDRV_CTL_POWER_D3hot);
        chip->in_suspend = 1;
-       snd_pcm_suspend_all(chip->pcm);
-#ifdef CONFIG_SND_CS46XX_NEW_DSP
-       snd_pcm_suspend_all(chip->pcm_rear);
-       snd_pcm_suspend_all(chip->pcm_center_lfe);
-       snd_pcm_suspend_all(chip->pcm_iec958);
-#endif
        // chip->ac97_powerdown = snd_cs46xx_codec_read(chip, AC97_POWER_CONTROL);
        // chip->ac97_general_purpose = snd_cs46xx_codec_read(chip, BA0_AC97_GENERAL_PURPOSE);
 
index 82bd10b68a77826caeef5a0026c09a354a3808ec..446ef1f1b45a0116d0a215c8813ec76dea98fd73 100644 (file)
@@ -62,7 +62,6 @@ static int __maybe_unused snd_cs5535audio_suspend(struct device *dev)
        int i;
 
        snd_power_change_state(card, SNDRV_CTL_POWER_D3hot);
-       snd_pcm_suspend_all(cs5535au->pcm);
        snd_ac97_suspend(cs5535au->ac97);
        for (i = 0; i < NUM_CS5535AUDIO_DMAS; i++) {
                struct cs5535audio_dma *dma = &cs5535au->dmas[i];
index 2ada8444abd99ba4d5d4ab14a59285eed87b61fb..e622613ea94728669b6ebd7c4a791cf4df28f2b8 100644 (file)
@@ -1548,18 +1548,10 @@ static void atc_connect_resources(struct ct_atc *atc)
 #ifdef CONFIG_PM_SLEEP
 static int atc_suspend(struct ct_atc *atc)
 {
-       int i;
        struct hw *hw = atc->hw;
 
        snd_power_change_state(atc->card, SNDRV_CTL_POWER_D3hot);
 
-       for (i = FRONT; i < NUM_PCMS; i++) {
-               if (!atc->pcms[i])
-                       continue;
-
-               snd_pcm_suspend_all(atc->pcms[i]);
-       }
-
        atc_release_resources(atc);
 
        hw->suspend(hw);
index 907cf1a467128bf44256da495d1d9e76d2f11498..18d30d479b6b51373da02024fec49572b43d64ea 100644 (file)
@@ -2165,9 +2165,6 @@ static int snd_echo_suspend(struct device *dev)
 {
        struct echoaudio *chip = dev_get_drvdata(dev);
 
-       snd_pcm_suspend_all(chip->analog_pcm);
-       snd_pcm_suspend_all(chip->digital_pcm);
-
 #ifdef ECHOCARD_HAS_MIDI
        /* This call can sleep */
        if (chip->midi_out)
index d3203df50a1a5cbc0c2c05beb4591282db80b534..3c41a0edcfb07105b861dbc7967874086c1090cd 100644 (file)
@@ -224,12 +224,6 @@ static int snd_emu10k1_suspend(struct device *dev)
 
        cancel_delayed_work_sync(&emu->emu1010.firmware_work);
 
-       snd_pcm_suspend_all(emu->pcm);
-       snd_pcm_suspend_all(emu->pcm_mic);
-       snd_pcm_suspend_all(emu->pcm_efx);
-       snd_pcm_suspend_all(emu->pcm_multi);
-       snd_pcm_suspend_all(emu->pcm_p16v);
-
        snd_ac97_suspend(emu->ac97);
 
        snd_emu10k1_efx_suspend(emu);
index 727eb3da1fda1efac90db415342af678854316a2..1f2960ecc57ef37ad1c78bc1802a9615914fecd4 100644 (file)
@@ -2037,9 +2037,6 @@ static int snd_ensoniq_suspend(struct device *dev)
        
        snd_power_change_state(card, SNDRV_CTL_POWER_D3hot);
 
-       snd_pcm_suspend_all(ensoniq->pcm1);
-       snd_pcm_suspend_all(ensoniq->pcm2);
-       
 #ifdef CHIP1371        
        snd_ac97_suspend(ensoniq->u.es1371.ac97);
 #else
index 9d248eb2e26cd7ecb9faca4eefdcd74561121b5f..84d07bce581cb796e7da0955e5c13ec3fc129b63 100644 (file)
@@ -1475,7 +1475,6 @@ static int es1938_suspend(struct device *dev)
        unsigned char *s, *d;
 
        snd_power_change_state(card, SNDRV_CTL_POWER_D3hot);
-       snd_pcm_suspend_all(chip->pcm);
 
        /* save mixer-related registers */
        for (s = saved_regs, d = chip->saved_regs; *s; s++, d++)
index 0b1845ca6005a187e6a567e5beda7582f44bca1a..9dcb698fc8c7124e166ddc74f1449677c78de107 100644 (file)
@@ -2392,7 +2392,6 @@ static int es1968_suspend(struct device *dev)
        chip->in_suspend = 1;
        cancel_work_sync(&chip->hwvol_work);
        snd_power_change_state(card, SNDRV_CTL_POWER_D3hot);
-       snd_pcm_suspend_all(chip->pcm);
        snd_ac97_suspend(chip->ac97);
        snd_es1968_bob_stop(chip);
        return 0;
index e3fb9c61017c6535e3d8fb4cb4f9694bce2e2bb1..1317f3183eb1b598a9a23194cf6da2c967da4051 100644 (file)
@@ -1408,7 +1408,6 @@ static int snd_fm801_suspend(struct device *dev)
        if (chip->tea575x_tuner & TUNER_ONLY) {
                /* FIXME: tea575x suspend */
        } else {
-               snd_pcm_suspend_all(chip->pcm);
                snd_ac97_suspend(chip->ac97);
                snd_ac97_suspend(chip->ac97_sec);
        }
index 9f8d59e7e89f4625afab833adf3e0f31fe6d1420..ff6dbed4d3cd44ab37a8d09bab34d82dddc9557b 100644 (file)
@@ -2927,8 +2927,6 @@ static int hda_codec_runtime_suspend(struct device *dev)
        unsigned int state;
 
        cancel_delayed_work_sync(&codec->jackpoll_work);
-       list_for_each_entry(pcm, &codec->pcm_list_head, list)
-               snd_pcm_suspend_all(pcm->pcm);
        state = hda_call_codec_suspend(codec);
        if (codec->link_down_at_suspend ||
            (codec_has_clkstop(codec) && codec_has_epss(codec) &&
index f1fe497c2f9df79be49ac64c3faec849d8c50cfa..dda9b26192cbc95ed52656c7554fee4eb83c13dc 100644 (file)
@@ -2792,9 +2792,6 @@ static int snd_ice1712_suspend(struct device *dev)
 
        snd_power_change_state(card, SNDRV_CTL_POWER_D3hot);
 
-       snd_pcm_suspend_all(ice->pcm);
-       snd_pcm_suspend_all(ice->pcm_pro);
-       snd_pcm_suspend_all(ice->pcm_ds);
        snd_ac97_suspend(ice->ac97);
 
        spin_lock_irq(&ice->reg_lock);
index 057c2f394ea7223eed508cf2e1d08cfcb8e647eb..42994cf3615688ef931d4a7e326f1c5be6286537 100644 (file)
@@ -2804,9 +2804,6 @@ static int snd_vt1724_suspend(struct device *dev)
 
        snd_power_change_state(card, SNDRV_CTL_POWER_D3hot);
 
-       snd_pcm_suspend_all(ice->pcm);
-       snd_pcm_suspend_all(ice->pcm_pro);
-       snd_pcm_suspend_all(ice->pcm_ds);
        snd_ac97_suspend(ice->ac97);
 
        spin_lock_irq(&ice->reg_lock);
index ffddcdfe0c6688efa4a027cc702cea82aa8876c6..885e1d488ed6e8f4060e5c693f32764f8f40a12b 100644 (file)
@@ -2614,8 +2614,6 @@ static int intel8x0_suspend(struct device *dev)
        int i;
 
        snd_power_change_state(card, SNDRV_CTL_POWER_D3hot);
-       for (i = 0; i < chip->pcm_devs; i++)
-               snd_pcm_suspend_all(chip->pcm[i]);
        for (i = 0; i < chip->ncodecs; i++)
                snd_ac97_suspend(chip->ac97[i]);
        if (chip->device_type == DEVICE_INTEL_ICH4)
index c84629190cbaf72fecb4769b5fd596a25fce1fbc..44eb9e28a1eb1bfd0fb1fb16129c825b05a78492 100644 (file)
@@ -1025,11 +1025,8 @@ static int intel8x0m_suspend(struct device *dev)
 {
        struct snd_card *card = dev_get_drvdata(dev);
        struct intel8x0m *chip = card->private_data;
-       int i;
 
        snd_power_change_state(card, SNDRV_CTL_POWER_D3hot);
-       for (i = 0; i < chip->pcm_devs; i++)
-               snd_pcm_suspend_all(chip->pcm[i]);
        snd_ac97_suspend(chip->ac97);
        if (chip->irq >= 0) {
                free_irq(chip->irq, chip);
index 62962178a9d72bee14767b00e5104ebaec0b127f..1a9468c14aaf6dc0d39f5338d582b9ac8d8c9845 100644 (file)
@@ -2422,7 +2422,6 @@ static int m3_suspend(struct device *dev)
        chip->in_suspend = 1;
        cancel_work_sync(&chip->hwvol_work);
        snd_power_change_state(card, SNDRV_CTL_POWER_D3hot);
-       snd_pcm_suspend_all(chip->pcm);
        snd_ac97_suspend(chip->ac97);
 
        msleep(10); /* give the assp a chance to idle.. */
index b97f4ea6b56c810948fc39ca0845eec0a060ca87..85e46ff44ac359b0ebf96ee090e890ef91a1a1cf 100644 (file)
@@ -1413,7 +1413,6 @@ static int nm256_suspend(struct device *dev)
        struct nm256 *chip = card->private_data;
 
        snd_power_change_state(card, SNDRV_CTL_POWER_D3hot);
-       snd_pcm_suspend_all(chip->pcm);
        snd_ac97_suspend(chip->ac97);
        chip->coeffs_current = 0;
        return 0;
index b4ef5804212db5b6580afbe002b446f2ac0d6cd7..6dce56c209aaad031064955124bc4ddfaa1afbbc 100644 (file)
@@ -744,13 +744,10 @@ static int oxygen_pci_suspend(struct device *dev)
 {
        struct snd_card *card = dev_get_drvdata(dev);
        struct oxygen *chip = card->private_data;
-       unsigned int i, saved_interrupt_mask;
+       unsigned int saved_interrupt_mask;
 
        snd_power_change_state(card, SNDRV_CTL_POWER_D3hot);
 
-       for (i = 0; i < PCM_COUNT; ++i)
-               snd_pcm_suspend(chip->streams[i]);
-
        if (chip->model.suspend)
                chip->model.suspend(chip);
 
index 23017e3bc76cc4c7abde2d1481d82e0d703c75f1..1d431c8052d67a0311c4765f0b5283cf361ead64 100644 (file)
@@ -1158,7 +1158,6 @@ static int riptide_suspend(struct device *dev)
 
        chip->in_suspend = 1;
        snd_power_change_state(card, SNDRV_CTL_POWER_D3hot);
-       snd_pcm_suspend_all(chip->pcm);
        snd_ac97_suspend(chip->ac97);
        return 0;
 }
index dcfa4d7a73e2bcb86e5e67fb495abe8dd26cdab6..c56702e6cb607a518631bf2cf61b4e8dde8bcaf7 100644 (file)
@@ -2388,8 +2388,6 @@ static int rme96_suspend(struct device *dev)
        struct rme96 *rme96 = card->private_data;
 
        snd_power_change_state(card, SNDRV_CTL_POWER_D3hot);
-       snd_pcm_suspend(rme96->playback_substream);
-       snd_pcm_suspend(rme96->capture_substream);
 
        /* save capture & playback pointers */
        rme96->playback_pointer = readl(rme96->iobase + RME96_IO_GET_PLAY_POS)
index 964acf302479ae45159fd930e540dca231ff7d98..6b27980d77a8d6d657a3d07f3b9f3a74aa0e58fc 100644 (file)
@@ -1214,7 +1214,6 @@ static int sis_suspend(struct device *dev)
        int i;
 
        snd_power_change_state(card, SNDRV_CTL_POWER_D3hot);
-       snd_pcm_suspend_all(sis->pcm);
        if (sis->codecs_present & SIS_PRIMARY_CODEC_PRESENT)
                snd_ac97_suspend(sis->ac97[0]);
        if (sis->codecs_present & SIS_SECONDARY_CODEC_PRESENT)
index 5523e193d556185837371378507150cfa95966ab..f271ea436cff3662be60e08581a37064690eeeae 100644 (file)
@@ -3915,10 +3915,6 @@ static int snd_trident_suspend(struct device *dev)
 
        trident->in_suspend = 1;
        snd_power_change_state(card, SNDRV_CTL_POWER_D3hot);
-       snd_pcm_suspend_all(trident->pcm);
-       snd_pcm_suspend_all(trident->foldback);
-       snd_pcm_suspend_all(trident->spdif);
-
        snd_ac97_suspend(trident->ac97);
        snd_ac97_suspend(trident->ac97_sec);
        return 0;
index c488c5afa19591410d4c872bd3decf531f0c4555..736ac79901b3f86589b63c6bfa12305084270d15 100644 (file)
@@ -2278,8 +2278,6 @@ static int snd_via82xx_suspend(struct device *dev)
        int i;
 
        snd_power_change_state(card, SNDRV_CTL_POWER_D3hot);
-       for (i = 0; i < 2; i++)
-               snd_pcm_suspend_all(chip->pcms[i]);
        for (i = 0; i < chip->num_devs; i++)
                snd_via82xx_channel_reset(chip, &chip->devs[i]);
        synchronize_irq(chip->irq);
index b13c8688cc8d98b947910a6a86653fc5b8b0d1ab..3f59e02790582e00109ca87c03fb7a2590c24b87 100644 (file)
@@ -1038,8 +1038,6 @@ static int snd_via82xx_suspend(struct device *dev)
        int i;
 
        snd_power_change_state(card, SNDRV_CTL_POWER_D3hot);
-       for (i = 0; i < 2; i++)
-               snd_pcm_suspend_all(chip->pcms[i]);
        for (i = 0; i < chip->num_devs; i++)
                snd_via82xx_channel_reset(chip, &chip->devs[i]);
        synchronize_irq(chip->irq);
index a4926fb03991fb216706697e4523662eefaa9744..c688b7f481da9a4d205a25069126ce52ab06a44b 100644 (file)
@@ -2304,10 +2304,6 @@ static int snd_ymfpci_suspend(struct device *dev)
        unsigned int i;
        
        snd_power_change_state(card, SNDRV_CTL_POWER_D3hot);
-       snd_pcm_suspend_all(chip->pcm);
-       snd_pcm_suspend_all(chip->pcm2);
-       snd_pcm_suspend_all(chip->pcm_spdif);
-       snd_pcm_suspend_all(chip->pcm_4ch);
        snd_ac97_suspend(chip->ac97);
        for (i = 0; i < YDSXGR_NUM_SAVED_REGS; i++)
                chip->saved_regs[i] = snd_ymfpci_readl(chip, saved_regs_index[i]);