staging: visornic: use skb_put_zero() instead of open-coded version
authorJann Horn <jannh@google.com>
Fri, 15 Feb 2019 18:16:16 +0000 (19:16 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 19 Feb 2019 14:35:25 +0000 (15:35 +0100)
Replace an open-coded version of skb_put_zero() with a call to the helper.
This is a cleanup and is also useful for potentially adding KASAN
integration to SKBs in the future.

Signed-off-by: Jann Horn <jannh@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/unisys/visornic/visornic_main.c

index 5eeb4b93b45bc2e1783f965a47addc313e73f732..1c1a470d2e50f03201b442174ba3af205abe4763 100644 (file)
@@ -896,9 +896,7 @@ static netdev_tx_t visornic_xmit(struct sk_buff *skb, struct net_device *netdev)
            ((skb_end_pointer(skb) - skb->data) >= ETH_MIN_PACKET_SIZE)) {
                /* pad the packet out to minimum size */
                padlen = ETH_MIN_PACKET_SIZE - len;
-               memset(&skb->data[len], 0, padlen);
-               skb->tail += padlen;
-               skb->len += padlen;
+               skb_put_zero(skb, padlen);
                len += padlen;
                firstfraglen += padlen;
        }