wifi: rtl8xxxu: fix error messages
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 31 Jan 2024 07:10:07 +0000 (10:10 +0300)
committerKalle Valo <kvalo@kernel.org>
Thu, 1 Feb 2024 10:21:02 +0000 (12:21 +0200)
The first parameter of WARN_ONCE() is a condition so this code will end
up printing the function name instead of the proper message.

Fixes: 3ff7a05996f9 ("wifi: rtl8xxxu: support setting bssid register for multiple interfaces")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://msgid.link/7b144531-a8da-4725-8911-9b614a525a35@moroto.mountain
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c

index 3b954c2fe448fa22633bf63de10c4c46ef9421ca..bd6fd3120562864c6d5957f594ee47d0f246c7b1 100644 (file)
@@ -3593,7 +3593,7 @@ static int rtl8xxxu_set_mac(struct rtl8xxxu_priv *priv, int port_num)
                reg = REG_MACID1;
                break;
        default:
-               WARN_ONCE("%s: invalid port_num\n", __func__);
+               WARN_ONCE(1, "%s: invalid port_num\n", __func__);
                return -EINVAL;
        }
 
@@ -3618,7 +3618,7 @@ static int rtl8xxxu_set_bssid(struct rtl8xxxu_priv *priv, const u8 *bssid, int p
                reg = REG_BSSID1;
                break;
        default:
-               WARN_ONCE("%s: invalid port_num\n", __func__);
+               WARN_ONCE(1, "%s: invalid port_num\n", __func__);
                return -EINVAL;
        }