bcachefs: Delete old assertion for online fsck
authorKent Overstreet <kent.overstreet@linux.dev>
Sun, 7 Apr 2024 03:58:01 +0000 (23:58 -0400)
committerKent Overstreet <kent.overstreet@linux.dev>
Sun, 14 Jul 2024 23:00:14 +0000 (19:00 -0400)
the order in which btree_gc walks keys have changed, so we no longer
have the sort of issues with online fsck this assertion was warning
about.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
fs/bcachefs/btree_trans_commit.c

index 30e24725eb123eeb02578cbeb9b625340ffabe29..585c41a13f4d613b242de0d16bdd431180abcce7 100644 (file)
@@ -603,20 +603,13 @@ static int bch2_trans_commit_run_triggers(struct btree_trans *trans)
 
 static noinline int bch2_trans_commit_run_gc_triggers(struct btree_trans *trans)
 {
-       trans_for_each_update(trans, i) {
-               /*
-                * XXX: synchronization of cached update triggers with gc
-                * XXX: synchronization of interior node updates with gc
-                */
-               BUG_ON(i->cached || i->level);
-
+       trans_for_each_update(trans, i)
                if (btree_node_type_needs_gc(__btree_node_type(i->level, i->btree_id)) &&
                    gc_visited(trans->c, gc_pos_btree_node(insert_l(trans, i)->b))) {
                        int ret = run_one_mem_trigger(trans, i, i->flags|BTREE_TRIGGER_gc);
                        if (ret)
                                return ret;
                }
-       }
 
        return 0;
 }