ipv4: ipv4_default_advmss() should use route mtu
authorEric Dumazet <edumazet@google.com>
Thu, 19 Oct 2017 00:02:03 +0000 (17:02 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sat, 21 Oct 2017 00:55:05 +0000 (01:55 +0100)
ipv4_default_advmss() incorrectly uses the device MTU instead
of the route provided one. IPv6 has the proper behavior,
lets harmonize the two protocols.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/route.c

index 4306db8273742f5e845635419c296823301c4a8b..bc40bd4111969f640603dd7c5b04fdb7fdcd4afd 100644 (file)
@@ -1250,7 +1250,7 @@ static void set_class_tag(struct rtable *rt, u32 tag)
 static unsigned int ipv4_default_advmss(const struct dst_entry *dst)
 {
        unsigned int header_size = sizeof(struct tcphdr) + sizeof(struct iphdr);
-       unsigned int advmss = max_t(unsigned int, dst->dev->mtu - header_size,
+       unsigned int advmss = max_t(unsigned int, ipv4_mtu(dst) - header_size,
                                    ip_rt_min_advmss);
 
        return min(advmss, IPV4_MAX_PMTU - header_size);