drm/amd/display: "Enable IPS by default"
authorRoman Li <Roman.Li@amd.com>
Tue, 23 Jan 2024 20:18:24 +0000 (15:18 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 25 Jan 2024 19:58:03 +0000 (14:58 -0500)
[Why]
IPS was temporary disabled due to instability.
It was fixed in dmub firmware and with:
- "drm/amd/display: Add IPS checks before dcn register access"
- "drm/amd/display: Disable ips before dc interrupt setting"

[How]
Enable IPS by default.
Disable IPS if 0x800 bit set in amdgpu.dcdebugmask module params

Signed-off-by: Roman Li <Roman.Li@amd.com>
Tested-by: Mark Broadworth <mark.broadworth@amd.com>
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

index 5716c6259f8d629a3acddb80c264fa15afe8c45d..d3dbbf2bb9472d667cc753a6502a5a46b9924671 100644 (file)
@@ -1720,7 +1720,8 @@ static int amdgpu_dm_init(struct amdgpu_device *adev)
        init_data.nbio_reg_offsets = adev->reg_offset[NBIO_HWIP][0];
        init_data.clk_reg_offsets = adev->reg_offset[CLK_HWIP][0];
 
-       init_data.flags.disable_ips = DMUB_IPS_DISABLE_ALL;
+       if (amdgpu_dc_debug_mask & DC_DISABLE_IPS)
+               init_data.flags.disable_ips = DMUB_IPS_DISABLE_ALL;
 
        init_data.flags.disable_ips_in_vpb = 1;