drm/i915: Disable RC6 before configuring in on VLV/CHV
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Mon, 19 Jan 2015 11:50:47 +0000 (13:50 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 27 Jan 2015 08:50:44 +0000 (09:50 +0100)
Follow the sequence in the BIOS spec and clear the RC_CONTROL register
before changing any of the other RC6/RP registers.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Deepak S<deepak.s@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_pm.c

index b73d601e72269597ab73a690de1ac7b73a3de5ba..e7f0f211cca7f59a02b19677cc83cdbcf28c36cc 100644 (file)
@@ -4712,6 +4712,9 @@ static void cherryview_enable_rps(struct drm_device *dev)
         * hasn't enabled a state yet where we need forcewake, BIOS may have.*/
        gen6_gt_force_wake_get(dev_priv, FORCEWAKE_ALL);
 
+       /*  Disable RC states. */
+       I915_WRITE(GEN6_RC_CONTROL, 0);
+
        /* 2a: Program RC6 thresholds.*/
        I915_WRITE(GEN6_RC6_WAKE_RATE_LIMIT, 40 << 16);
        I915_WRITE(GEN6_RC_EVALUATION_INTERVAL, 125000); /* 12500 * 1280ns */
@@ -4801,6 +4804,9 @@ static void valleyview_enable_rps(struct drm_device *dev)
        /* If VLV, Forcewake all wells, else re-direct to regular path */
        gen6_gt_force_wake_get(dev_priv, FORCEWAKE_ALL);
 
+       /*  Disable RC states. */
+       I915_WRITE(GEN6_RC_CONTROL, 0);
+
        I915_WRITE(GEN6_RP_UP_THRESHOLD, 59400);
        I915_WRITE(GEN6_RP_DOWN_THRESHOLD, 245000);
        I915_WRITE(GEN6_RP_UP_EI, 66000);