drm/amdgpu: validate user queue parameters

Make sure these are set properly to ensure compatibility if
we ever update the IOCTL interface.

Reviewed-by: Prike Liang <Prike.Liang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c
index a78a3728f6b8061a61a203293ea5ebaae86e66bb..a02614cbda36e29bc8505dcaaed4316f23f72bb2 100644 (file)
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c
@@ -380,12 +380,26 @@ int amdgpu_userq_ioctl(struct drm_device *dev, void *data,
 
        switch (args->in.op) {
        case AMDGPU_USERQ_OP_CREATE:
+               if (args->in._pad)
+                       return -EINVAL;
                r = amdgpu_userqueue_create(filp, args);
                if (r)
                        DRM_ERROR("Failed to create usermode queue\n");
                break;
 
        case AMDGPU_USERQ_OP_FREE:
+               if (args->in.ip_type ||
+                   args->in.doorbell_handle ||
+                   args->in.doorbell_offset ||
+                   args->in._pad ||
+                   args->in.queue_va ||
+                   args->in.queue_size ||
+                   args->in.rptr_va ||
+                   args->in.wptr_va ||
+                   args->in.wptr_va ||
+                   args->in.mqd ||
+                   args->in.mqd_size)
+                       return -EINVAL;
                r = amdgpu_userqueue_destroy(filp, args->in.queue_id);
                if (r)
                        DRM_ERROR("Failed to destroy usermode queue\n");