vhost_vsock: simplify vhost_vsock_flush()
authorAndrey Ryabinin <arbn@yandex-team.com>
Tue, 17 May 2022 18:08:47 +0000 (13:08 -0500)
committerMichael S. Tsirkin <mst@redhat.com>
Tue, 31 May 2022 16:45:10 +0000 (12:45 -0400)
vhost_vsock_flush() calls vhost_work_dev_flush(vsock->vqs[i].poll.dev)
before vhost_work_dev_flush(&vsock->dev). This seems pointless
as vsock->vqs[i].poll.dev is the same as &vsock->dev and several flushes
in a row doesn't do anything useful, one is just enough.

Signed-off-by: Andrey Ryabinin <arbn@yandex-team.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Signed-off-by: Mike Christie <michael.christie@oracle.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Message-Id: <20220517180850.198915-6-michael.christie@oracle.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
drivers/vhost/vsock.c

index a4c8ae92a0fb25a1c4b663c01f91428d452cad89..96be63697117c74063e072ea00f3e6b7b044bcdf 100644 (file)
@@ -705,11 +705,6 @@ out:
 
 static void vhost_vsock_flush(struct vhost_vsock *vsock)
 {
-       int i;
-
-       for (i = 0; i < ARRAY_SIZE(vsock->vqs); i++)
-               if (vsock->vqs[i].handle_kick)
-                       vhost_work_dev_flush(vsock->vqs[i].poll.dev);
        vhost_work_dev_flush(&vsock->dev);
 }