drm/amd/display: fix duplicate assignments
authorArnd Bergmann <arnd@arndb.de>
Thu, 15 Dec 2022 16:45:25 +0000 (17:45 +0100)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 20 Dec 2022 17:46:27 +0000 (12:46 -0500)
The .set_odm_combine callback pointer was added twice, causing
a harmless -Wextra warning:

drivers/gpu/drm/amd/amdgpu/../display/dc/dcn314/dcn314_optc.c:258:36: error: initialized field overwritten [-Werror=override-init]
  258 |                 .set_odm_combine = optc314_set_odm_combine,
      |                                    ^~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn314/dcn314_optc.c:258:36: note: (near initialization for 'dcn314_tg_funcs.set_odm_combine')

Fixes: 5ade1b951dec ("drm/amd/display: Add OTG/ODM functions")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c

index f246aab23050f64ea15671edffb7ac24c8ece556..0086cafb0f7a82230492ef967ef8d621f258c38b 100644 (file)
@@ -241,7 +241,6 @@ static struct timing_generator_funcs dcn314_tg_funcs = {
                .set_dsc_config = optc3_set_dsc_config,
                .get_dsc_status = optc2_get_dsc_status,
                .set_dwb_source = NULL,
-               .set_odm_combine = optc314_set_odm_combine,
                .get_optc_source = optc2_get_optc_source,
                .set_out_mux = optc3_set_out_mux,
                .set_drr_trigger_window = optc3_set_drr_trigger_window,