media: ivsc: csi: Don't parse remote endpoints
authorSakari Ailus <sakari.ailus@linux.intel.com>
Mon, 16 Oct 2023 07:18:29 +0000 (10:18 +0300)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Wed, 22 Nov 2023 09:56:34 +0000 (10:56 +0100)
The driver parsed, besides its own endpoint on the sink, the remote
upstream endpoint that most likely is a sensor, and took the number of
lanes from that. Instead obtain the number of lanes from the local
endpoint.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Tested-by: Wentong Wu <wentong.wu@intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/media/pci/intel/ivsc/mei_csi.c

index 2a6b828fd8dd537e942352204f6d895ab01e3ec6..790b1101d57998357ab0cc91a04a8b679ccc7508 100644 (file)
@@ -662,6 +662,8 @@ static int mei_csi_parse_firmware(struct mei_csi *csi)
                return -EINVAL;
        }
 
+       csi->nr_of_lanes = v4l2_ep.bus.mipi_csi2.num_data_lanes;
+
        fwnode = fwnode_graph_get_remote_endpoint(ep);
        fwnode_handle_put(ep);
 
@@ -675,18 +677,12 @@ static int mei_csi_parse_firmware(struct mei_csi *csi)
                return PTR_ERR(asd);
        }
 
-       ret = v4l2_fwnode_endpoint_alloc_parse(fwnode, &v4l2_ep);
        fwnode_handle_put(fwnode);
-       if (ret)
-               return ret;
-       csi->nr_of_lanes = v4l2_ep.bus.mipi_csi2.num_data_lanes;
 
        ret = v4l2_async_nf_register(&csi->notifier);
        if (ret)
                v4l2_async_nf_cleanup(&csi->notifier);
 
-       v4l2_fwnode_endpoint_free(&v4l2_ep);
-
        return ret;
 }