perf disasm: Fix not cleaning up disasm_line in symbol__disassemble_raw()

In symbol__disassemble_raw(), the created disasm_line should be
discarded before returning an error. When creating disasm_line fails,
break the loop and then release the created lines.

Fixes: 0b971e6bf1c3 ("perf annotate: Add support to capture and parse raw instruction in powerpc using dso__data_read_offset utility")
Signed-off-by: Li Huafei <lihuafei1@huawei.com>
Tested-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
Cc: sesse@google.com
Cc: kjain@linux.ibm.com
Link: https://lore.kernel.org/r/20241019154157.282038-3-lihuafei1@huawei.com
Signed-off-by: Namhyung Kim <namhyung@kernel.org>

diff --git a/tools/perf/util/disasm.c b/tools/perf/util/disasm.c
index 5fdd5afc5c2fa3b0226a1779dbd569d3a39ae7c1..bd98fec903f731719fd223c42661d8af58ee8803 100644 (file)
--- a/tools/perf/util/disasm.c
+++ b/tools/perf/util/disasm.c
@@ -1773,7 +1773,7 @@ static int symbol__disassemble_raw(char *filename, struct symbol *sym,
                sprintf(args->line, "%x", line[i]);
                dl = disasm_line__new(args);
                if (dl == NULL)
-                       goto err;
+                       break;
 
                annotation_line__add(&dl->al, &notes->src->source);
                offset += 4;