ext4: return error on syncfs after shutdown

This is the logic behavior and one that we would like to verify
using a generic fstest similar to xfs/546.

Link: https://lore.kernel.org/fstests/20240830152648.GE6216@frogsfrogsfrogs/
Suggested-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://patch.msgid.link/20240904084657.1062243-1-amir73il@gmail.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index e7d3c2e209ba19b117aa5b130f52b517e4c7d348..e4bdb896e2025d0a2e4325fd81fadb37f338e0cb 100644 (file)
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -6304,7 +6304,7 @@ static int ext4_sync_fs(struct super_block *sb, int wait)
        struct ext4_sb_info *sbi = EXT4_SB(sb);
 
        if (unlikely(ext4_forced_shutdown(sb)))
-               return 0;
+               return -EIO;
 
        trace_ext4_sync_fs(sb, wait);
        flush_workqueue(sbi->rsv_conversion_wq);