projects
/
linux-block.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
9c6e02e
)
dmaengine: ti: edma: handle irq_of_parse_and_map() errors
author
Dan Carpenter
<dan.carpenter@linaro.org>
Fri, 15 Sep 2023 12:59:59 +0000
(15:59 +0300)
committer
Vinod Koul
<vkoul@kernel.org>
Mon, 2 Oct 2023 15:58:33 +0000
(21:28 +0530)
Zero is not a valid IRQ for in-kernel code and the irq_of_parse_and_map()
function returns zero on error. So this check for valid IRQs should only
accept values > 0.
Fixes:
2b6b3b742019
("ARM/dmaengine: edma: Merge the two drivers under drivers/dma/")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by: Peter Ujfalusi <peter.ujfalusi@gmail.com>
Link:
https://lore.kernel.org/r/f15cb6a7-8449-4f79-98b6-34072f04edbc@moroto.mountain
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/ti/edma.c
patch
|
blob
|
blame
|
history
diff --git
a/drivers/dma/ti/edma.c
b/drivers/dma/ti/edma.c
index fe06288e034bb640cdc52b3682aaa1271fb734ef..f1f920861fa9d8937a34bc29906778720a8dbfd8 100644
(file)
--- a/
drivers/dma/ti/edma.c
+++ b/
drivers/dma/ti/edma.c
@@
-2401,7
+2401,7
@@
static int edma_probe(struct platform_device *pdev)
if (irq < 0 && node)
irq = irq_of_parse_and_map(node, 0);
- if (irq >
=
0) {
+ if (irq > 0) {
irq_name = devm_kasprintf(dev, GFP_KERNEL, "%s_ccint",
dev_name(dev));
ret = devm_request_irq(dev, irq, dma_irq_handler, 0, irq_name,
@@
-2417,7
+2417,7
@@
static int edma_probe(struct platform_device *pdev)
if (irq < 0 && node)
irq = irq_of_parse_and_map(node, 2);
- if (irq >
=
0) {
+ if (irq > 0) {
irq_name = devm_kasprintf(dev, GFP_KERNEL, "%s_ccerrint",
dev_name(dev));
ret = devm_request_irq(dev, irq, dma_ccerr_handler, 0, irq_name,