ionic: advertise 52-bit addressing limitation for MSI-X
authorDavid Christensen <drc@linux.ibm.com>
Mon, 3 Jun 2024 21:27:41 +0000 (17:27 -0400)
committerJakub Kicinski <kuba@kernel.org>
Wed, 5 Jun 2024 22:53:22 +0000 (15:53 -0700)
Current ionic devices only support 52 internal physical address
lines. This is sufficient for x86_64 systems which have similar
limitations but does not apply to all other architectures,
notably IBM POWER (ppc64). To ensure that MSI/MSI-X vectors are
not set outside the physical address limits of the NIC, set the
no_64bit_msi value of the pci_dev structure during device probe.

Signed-off-by: David Christensen <drc@linux.ibm.com>
Reviewed-by: Shannon Nelson <shannon.nelson@amd.com>
Link: https://lore.kernel.org/r/20240603212747.1079134-1-drc@linux.ibm.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/pensando/ionic/ionic_bus_pci.c

index 6ba8d4aca0a038b88e7f3ae3a8299ea0a55bd7e0..a7146d50f81428bcea7cc716f188328ed5555726 100644 (file)
@@ -326,6 +326,11 @@ static int ionic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
                goto err_out;
        }
 
+#ifdef CONFIG_PPC64
+       /* Ensure MSI/MSI-X interrupts lie within addressable physical memory */
+       pdev->no_64bit_msi = 1;
+#endif
+
        err = ionic_setup_one(ionic);
        if (err)
                goto err_out;