octeontx2-pf: Fix missing spin_lock_init() in otx2_tc_add_flow()
authorWei Yongjun <weiyongjun1@huawei.com>
Fri, 19 Mar 2021 09:41:03 +0000 (09:41 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 19 Mar 2021 19:09:22 +0000 (12:09 -0700)
The driver allocates the spinlock but not initialize it.
Use spin_lock_init() on it to initialize it correctly.

Fixes: d8ce30e0cf76 ("octeontx2-pf: add tc flower stats handler for hw offloads")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/marvell/octeontx2/nic/otx2_tc.c

index 2f75cfc5a23ad24a8e61c37a3b0bfcdc45da3e2b..e919140d89652589095fbac602a7fcfed9359983 100644 (file)
@@ -536,6 +536,7 @@ static int otx2_tc_add_flow(struct otx2_nic *nic,
        new_node = kzalloc(sizeof(*new_node), GFP_KERNEL);
        if (!new_node)
                return -ENOMEM;
+       spin_lock_init(&new_node->lock);
        new_node->cookie = tc_flow_cmd->cookie;
 
        mutex_lock(&nic->mbox.lock);