drm/scheduler: fix drm_sched_job_add_implicit_dependencies
authorChristian König <christian.koenig@amd.com>
Mon, 18 Oct 2021 19:27:55 +0000 (21:27 +0200)
committerChristian König <christian.koenig@amd.com>
Tue, 19 Oct 2021 13:11:26 +0000 (15:11 +0200)
Trivial fix since we now need to grab a reference to the fence we have
added. Previously the dma_resv function where doing that for us.

Signed-off-by: Christian König <christian.koenig@amd.com>
Fixes: 9c2ba265352a ("drm/scheduler: use new iterator in drm_sched_job_add_implicit_dependencies v2")
Link: https://patchwork.freedesktop.org/patch/msgid/20211019112706.27769-1-christian.koenig@amd.com
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Reported-by: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
References: https://lore.kernel.org/dri-devel/2023306.UmlnhvANQh@archbook/
Tested-by: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
drivers/gpu/drm/scheduler/sched_main.c

index 5bc5f775abe1ef10a4ab467072f3a4ba13d81aab..94fe51b3caa20a0b30b0e034d0b65095673989a9 100644 (file)
@@ -707,6 +707,9 @@ int drm_sched_job_add_implicit_dependencies(struct drm_sched_job *job,
                ret = drm_sched_job_add_dependency(job, fence);
                if (ret)
                        return ret;
+
+               /* Make sure to grab an additional ref on the added fence */
+               dma_fence_get(fence);
        }
        return 0;
 }