dmaengine: ti: edma: fix null dereference because of a typo in pointer name
authorColin Ian King <colin.king@canonical.com>
Wed, 26 Feb 2020 18:59:21 +0000 (18:59 +0000)
committerVinod Koul <vkoul@kernel.org>
Mon, 2 Mar 2020 10:09:15 +0000 (15:39 +0530)
Currently there is a dereference of the null pointer m_ddev.  This appears
to be a typo on the pointer, I believe s_ddev should be used instead.
Fix this by using the correct pointer.

Fixes: eb0249d50153 ("dmaengine: ti: edma: Support for interleaved mem to mem transfer")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Addresses-Coverity: ("Explicit null dereferenced")
Link: https://lore.kernel.org/r/20200226185921.351693-1-colin.king@canonical.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/ti/edma.c

index 2b1fdd438e7f2bcba2da5c399f904a3b04cfa1c8..c4a5c170c1f9698cf3052f725ad15d5c40c97bbd 100644 (file)
@@ -1992,7 +1992,7 @@ static void edma_dma_init(struct edma_cc *ecc, bool legacy_mode)
                         "Legacy memcpy is enabled, things might not work\n");
 
                dma_cap_set(DMA_MEMCPY, s_ddev->cap_mask);
-               dma_cap_set(DMA_INTERLEAVE, m_ddev->cap_mask);
+               dma_cap_set(DMA_INTERLEAVE, s_ddev->cap_mask);
                s_ddev->device_prep_dma_memcpy = edma_prep_dma_memcpy;
                s_ddev->device_prep_interleaved_dma = edma_prep_dma_interleaved;
                s_ddev->directions = BIT(DMA_MEM_TO_MEM);