staging: media: ipu3: Drop superfluous check in imgu_vb2_stop_streaming()
authorMax Staudt <mstaudt@chromium.org>
Thu, 20 Jun 2024 14:45:41 +0000 (23:45 +0900)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Sat, 31 Aug 2024 07:40:42 +0000 (09:40 +0200)
The check for imgu_all_nodes_streaming() seems superfluous, since
imgu->streaming can only become true once imgu_all_nodes_streaming()
has been true. Hence, checking for imgu->streaming == true should
imply imgu_all_nodes_streaming(), and therefore suffice.

Signed-off-by: Max Staudt <mstaudt@chromium.org>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/staging/media/ipu3/ipu3-v4l2.c

index 3df58eb3e8822b5eea8c3e70937841be6f2ca31c..541556037c422f3fed6d21a666c0c4685de08228 100644 (file)
@@ -548,7 +548,7 @@ static void imgu_vb2_stop_streaming(struct vb2_queue *vq)
 
        mutex_lock(&imgu->streaming_lock);
        /* Was this the first node with streaming disabled? */
-       if (imgu->streaming && imgu_all_nodes_streaming(imgu, node)) {
+       if (imgu->streaming) {
                /* Yes, really stop streaming now */
                dev_dbg(dev, "IMGU streaming is ready to stop");
                r = imgu_s_stream(imgu, false);