media: msp3400: use semicolons rather than commas to separate statements
authorJulia Lawall <Julia.Lawall@inria.fr>
Tue, 29 Sep 2020 13:14:35 +0000 (15:14 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Mon, 16 Nov 2020 09:31:07 +0000 (10:31 +0100)
Replace commas with semicolons.  Commas introduce unnecessary
variability in the code structure and are hard to see.  What is done
is essentially described by the following Coccinelle semantic patch
(http://coccinelle.lip6.fr/):

// <smpl>
@@ expression e1,e2; @@
e1
-,
+;
e2
... when any
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/i2c/msp3400-kthreads.c

index 52e506f86de525ec9c7d7b1bdbb1cf1ed330c8c6..ecabc0e1d32e6ed09179ec38f5cae2938b42292f 100644 (file)
@@ -549,8 +549,10 @@ restart:
                        val = msp_read_dsp(client, 0x1b);
                        if (val > 32767)
                                val -= 65536;
-                       if (val1 < val)
-                               val1 = val, max1 = i;
+                       if (val1 < val) {
+                               val1 = val;
+                               max1 = i;
+                       }
                        dev_dbg_lvl(&client->dev, 1, msp_debug,
                                "carrier1 val: %5d / %s\n", val, cd[i].name);
                }
@@ -586,8 +588,10 @@ restart:
                        val = msp_read_dsp(client, 0x1b);
                        if (val > 32767)
                                val -= 65536;
-                       if (val2 < val)
-                               val2 = val, max2 = i;
+                       if (val2 < val) {
+                               val2 = val;
+                               max2 = i;
+                       }
                        dev_dbg_lvl(&client->dev, 1, msp_debug,
                                "carrier2 val: %5d / %s\n", val, cd[i].name);
                }