accel/ivpu: Do not use irqsave in ivpu_ipc_dispatch
authorStanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
Mon, 13 Nov 2023 17:02:49 +0000 (18:02 +0100)
committerJacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
Thu, 16 Nov 2023 12:41:49 +0000 (13:41 +0100)
ivpu_ipc_dispatch is always called with irqs disabled. Add lockdep
assertion and remove unneeded _irqsave/_irqrestore.

Signed-off-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
Signed-off-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20231113170252.758137-3-jacek.lawrynowicz@linux.intel.com
drivers/accel/ivpu/ivpu_ipc.c

index 31ae0e71a8a363400ba9ca769b4aec2566ec8fd4..781c7e40505a66618641e7b5a08f2100c0c1b059 100644 (file)
@@ -367,9 +367,9 @@ ivpu_ipc_dispatch(struct ivpu_device *vdev, struct ivpu_ipc_consumer *cons,
 {
        struct ivpu_ipc_info *ipc = vdev->ipc;
        struct ivpu_ipc_rx_msg *rx_msg;
-       unsigned long flags;
 
        lockdep_assert_held(&ipc->cons_list_lock);
+       lockdep_assert_irqs_disabled();
 
        rx_msg = kzalloc(sizeof(*rx_msg), GFP_ATOMIC);
        if (!rx_msg) {
@@ -382,9 +382,9 @@ ivpu_ipc_dispatch(struct ivpu_device *vdev, struct ivpu_ipc_consumer *cons,
        rx_msg->ipc_hdr = ipc_hdr;
        rx_msg->jsm_msg = jsm_msg;
 
-       spin_lock_irqsave(&cons->rx_lock, flags);
+       spin_lock(&cons->rx_lock);
        list_add_tail(&rx_msg->link, &cons->rx_msg_list);
-       spin_unlock_irqrestore(&cons->rx_lock, flags);
+       spin_unlock(&cons->rx_lock);
 
        wake_up(&cons->rx_msg_wq);
 }