crypto: inside-secure/eip93 - acquire lock on eip93_put_descriptor hash

In the EIP93 HASH functions, the eip93_put_descriptor is called without
acquiring lock. This is problematic when multiple thread execute hash
operations.

Correctly acquire ring write lock on calling eip93_put_descriptor to
prevent concurrent access and mess with the ring pointers.

Fixes: 9739f5f93b78 ("crypto: eip93 - Add Inside Secure SafeXcel EIP-93 crypto engine support")
Reported-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/drivers/crypto/inside-secure/eip93/eip93-hash.c b/drivers/crypto/inside-secure/eip93/eip93-hash.c
index 5e9627467a42406358d6b2ff5aa13d45fcb3ea09..df1b05ac5a5799503cbd31cfdc7d18153584642a 100644 (file)
--- a/drivers/crypto/inside-secure/eip93/eip93-hash.c
+++ b/drivers/crypto/inside-secure/eip93/eip93-hash.c
@@ -260,7 +260,8 @@ static int eip93_send_hash_req(struct crypto_async_request *async, u8 *data,
        }
 
 again:
-       ret = eip93_put_descriptor(eip93, &cdesc);
+       scoped_guard(spinlock_irqsave, &eip93->ring->write_lock)
+               ret = eip93_put_descriptor(eip93, &cdesc);
        if (ret) {
                usleep_range(EIP93_RING_BUSY_DELAY,
                             EIP93_RING_BUSY_DELAY * 2);