mm: remove redundant return in set_huge_zero_folio()
authorDev Jain <dev.jain@arm.com>
Thu, 6 Mar 2025 14:43:15 +0000 (20:13 +0530)
committerAndrew Morton <akpm@linux-foundation.org>
Tue, 18 Mar 2025 05:06:57 +0000 (22:06 -0700)
It is the responsibility of the caller to check pmd_none(); in any case,
we are not achieving anything by returning since there is no return value
to tell the caller that we succeeded or not.  So remove this check.

Link: https://lkml.kernel.org/r/20250306144315.21907-1-dev.jain@arm.com
Signed-off-by: Dev Jain <dev.jain@arm.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Cc: Matthew Wilcow (Oracle) <willy@infradead.org>
Cc: Ryan Roberts <ryan.roberts@arm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/huge_memory.c

index 7433369d5d1f538e5fbc592d96150f40c13468ab..80cf15116ce70ca10573ec5387cd2eed6cad9c6c 100644 (file)
@@ -1309,8 +1309,6 @@ static void set_huge_zero_folio(pgtable_t pgtable, struct mm_struct *mm,
                struct folio *zero_folio)
 {
        pmd_t entry;
-       if (!pmd_none(*pmd))
-               return;
        entry = mk_pmd(&zero_folio->page, vma->vm_page_prot);
        entry = pmd_mkhuge(entry);
        pgtable_trans_huge_deposit(mm, pmd, pgtable);