mfd: timberdale: Remove redundant assignment to variable err
authorColin Ian King <colin.i.king@gmail.com>
Mon, 15 Apr 2024 10:26:32 +0000 (11:26 +0100)
committerLee Jones <lee@kernel.org>
Fri, 10 May 2024 14:39:17 +0000 (15:39 +0100)
The variable err is being assigned -ENODEV and then err is being
re-assigned the same error value via the error exit label err_mfd.
The assignment is redundant and can be removed.

Cleans up clang scan build warning:
drivers/mfd/timberdale.c:768:3: warning: Value stored to 'err' is
never read [deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Link: https://lore.kernel.org/r/20240415102632.484411-1-colin.i.king@gmail.com
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/mfd/timberdale.c

index 07e5aa10a146f33ed95a8bd572d1a4304375f418..a41e9a3e20648539b98ab333a671dd1df75d5d95 100644 (file)
@@ -765,7 +765,6 @@ static int timb_probe(struct pci_dev *dev,
        default:
                dev_err(&dev->dev, "Unknown IP setup: %d.%d.%d\n",
                        priv->fw.major, priv->fw.minor, ip_setup);
-               err = -ENODEV;
                goto err_mfd;
        }