tracing: Be more clever when dumping hex in __print_hex()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tue, 6 Aug 2019 15:15:43 +0000 (18:15 +0300)
committerSteven Rostedt (VMware) <rostedt@goodmis.org>
Tue, 17 Sep 2019 15:21:28 +0000 (11:21 -0400)
Hex dump as many as 16 bytes at once in trace_print_hex_seq()
instead of byte-by-byte approach.

Link: http://lkml.kernel.org/r/20190806151543.86061-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
kernel/trace/trace_output.c

index cab4a5398f1d4a746470f6ec4a88bc2da13860f7..d54ce252b05a848edb5d05ff3f32132975634b2c 100644 (file)
@@ -219,10 +219,10 @@ trace_print_hex_seq(struct trace_seq *p, const unsigned char *buf, int buf_len,
 {
        int i;
        const char *ret = trace_seq_buffer_ptr(p);
+       const char *fmt = concatenate ? "%*phN" : "%*ph";
 
-       for (i = 0; i < buf_len; i++)
-               trace_seq_printf(p, "%s%2.2x", concatenate || i == 0 ? "" : " ",
-                                buf[i]);
+       for (i = 0; i < buf_len; i += 16)
+               trace_seq_printf(p, fmt, min(buf_len - i, 16), &buf[i]);
        trace_seq_putc(p, 0);
 
        return ret;