spi: micro: fix unreasonable clk_prepare_enable() on error in mchp_corespi_probe()
authorPeng Wu <wupeng58@huawei.com>
Sat, 11 Jun 2022 02:11:17 +0000 (02:11 +0000)
committerMark Brown <broonie@kernel.org>
Mon, 13 Jun 2022 14:55:42 +0000 (15:55 +0100)
Fix the unreasonable clk_prepare_enable() with clk_disable_unprepare()
before return from mchp_corespi_probe() in the error handling case.

Signed-off-by: Peng Wu <wupeng58@huawei.com>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Link: https://lore.kernel.org/r/20220611021117.40494-1-wupeng58@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-microchip-core.c

index 3bd285dd49649c23eb9e3e871cff4eea4670584f..5b22a1395554dc6c5eaaaeb68767c9dda6f20090 100644 (file)
@@ -580,7 +580,7 @@ static int mchp_corespi_probe(struct platform_device *pdev)
 
 error_release_hardware:
        mchp_corespi_disable(spi);
-       clk_prepare_enable(spi->clk);
+       clk_disable_unprepare(spi->clk);
 error_release_master:
        spi_master_put(master);