mac80211: start pending scan after probe/auth/assoc timed out
authorHelmut Schaa <helmut.schaa@googlemail.com>
Thu, 12 Mar 2009 13:04:34 +0000 (14:04 +0100)
committerJohn W. Linville <linville@tuxdriver.com>
Sat, 28 Mar 2009 00:12:45 +0000 (20:12 -0400)
If a scan is queued in STA mode while the interface is in state direct
probe, authenticate or associate the scan is delayed until the interface
enters disabled or associated state. But in case of direct probe-,
authentication- or association- timeout sta_work will not be scheduled
anymore (without external trigger) and thus the pending scan is not
executed and prevents a new scan from being triggered (-EBUSY).

Fix this by queueing the sta work again after direct probe-, authentication-
and association- timeout.

Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
net/mac80211/mlme.c

index aaf7793583a785ce2cb0f88825d45dfb83a2ce49..a55879663b3c8394de6a4e4fff1a7ab575d26e2c 100644 (file)
@@ -682,6 +682,7 @@ static void ieee80211_set_associated(struct ieee80211_sub_if_data *sdata,
 static void ieee80211_direct_probe(struct ieee80211_sub_if_data *sdata)
 {
        struct ieee80211_if_managed *ifmgd = &sdata->u.mgd;
+       struct ieee80211_local *local = sdata->local;
 
        ifmgd->direct_probe_tries++;
        if (ifmgd->direct_probe_tries > IEEE80211_AUTH_MAX_TRIES) {
@@ -697,6 +698,13 @@ static void ieee80211_direct_probe(struct ieee80211_sub_if_data *sdata)
                ieee80211_rx_bss_remove(sdata, ifmgd->bssid,
                                sdata->local->hw.conf.channel->center_freq,
                                ifmgd->ssid, ifmgd->ssid_len);
+
+               /*
+                * We might have a pending scan which had no chance to run yet
+                * due to state == IEEE80211_STA_MLME_DIRECT_PROBE.
+                * Hence, queue the STAs work again
+                */
+               queue_work(local->hw.workqueue, &ifmgd->work);
                return;
        }
 
@@ -721,6 +729,7 @@ static void ieee80211_direct_probe(struct ieee80211_sub_if_data *sdata)
 static void ieee80211_authenticate(struct ieee80211_sub_if_data *sdata)
 {
        struct ieee80211_if_managed *ifmgd = &sdata->u.mgd;
+       struct ieee80211_local *local = sdata->local;
 
        ifmgd->auth_tries++;
        if (ifmgd->auth_tries > IEEE80211_AUTH_MAX_TRIES) {
@@ -732,6 +741,13 @@ static void ieee80211_authenticate(struct ieee80211_sub_if_data *sdata)
                ieee80211_rx_bss_remove(sdata, ifmgd->bssid,
                                sdata->local->hw.conf.channel->center_freq,
                                ifmgd->ssid, ifmgd->ssid_len);
+
+               /*
+                * We might have a pending scan which had no chance to run yet
+                * due to state == IEEE80211_STA_MLME_AUTHENTICATE.
+                * Hence, queue the STAs work again
+                */
+               queue_work(local->hw.workqueue, &ifmgd->work);
                return;
        }
 
@@ -878,6 +894,7 @@ static int ieee80211_privacy_mismatch(struct ieee80211_sub_if_data *sdata)
 static void ieee80211_associate(struct ieee80211_sub_if_data *sdata)
 {
        struct ieee80211_if_managed *ifmgd = &sdata->u.mgd;
+       struct ieee80211_local *local = sdata->local;
 
        ifmgd->assoc_tries++;
        if (ifmgd->assoc_tries > IEEE80211_ASSOC_MAX_TRIES) {
@@ -889,6 +906,12 @@ static void ieee80211_associate(struct ieee80211_sub_if_data *sdata)
                ieee80211_rx_bss_remove(sdata, ifmgd->bssid,
                                sdata->local->hw.conf.channel->center_freq,
                                ifmgd->ssid, ifmgd->ssid_len);
+               /*
+                * We might have a pending scan which had no chance to run yet
+                * due to state == IEEE80211_STA_MLME_ASSOCIATE.
+                * Hence, queue the STAs work again
+                */
+               queue_work(local->hw.workqueue, &ifmgd->work);
                return;
        }