drm/i915: pass dev_priv explicitly to PIPE_WGC_C01_C00
authorJani Nikula <jani.nikula@intel.com>
Mon, 29 Apr 2024 14:02:16 +0000 (17:02 +0300)
committerJani Nikula <jani.nikula@intel.com>
Tue, 30 Apr 2024 09:14:50 +0000 (12:14 +0300)
Avoid the implicit dev_priv local variable use, and pass dev_priv
explicitly to the PIPE_WGC_C01_C00 register macro.

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/85b3db6e666a7a629b10b482b7e7043d52d30511.1714399071.git.jani.nikula@intel.com
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/display/intel_color.c
drivers/gpu/drm/i915/display/intel_color_regs.h

index edb805fc9c9705599be86b7e12e80a3bc86dc197..cdcf8e796335f4cda9b45b23bfc456d8f2250518 100644 (file)
@@ -616,7 +616,7 @@ static void vlv_load_wgc_csc(struct intel_crtc *crtc,
        struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
        enum pipe pipe = crtc->pipe;
 
-       intel_de_write_fw(dev_priv, PIPE_WGC_C01_C00(pipe),
+       intel_de_write_fw(dev_priv, PIPE_WGC_C01_C00(dev_priv, pipe),
                          csc->coeff[1] << 16 | csc->coeff[0]);
        intel_de_write_fw(dev_priv, PIPE_WGC_C02(pipe),
                          csc->coeff[2]);
@@ -639,7 +639,7 @@ static void vlv_read_wgc_csc(struct intel_crtc *crtc,
        enum pipe pipe = crtc->pipe;
        u32 tmp;
 
-       tmp = intel_de_read_fw(dev_priv, PIPE_WGC_C01_C00(pipe));
+       tmp = intel_de_read_fw(dev_priv, PIPE_WGC_C01_C00(dev_priv, pipe));
        csc->coeff[0] = tmp & 0xffff;
        csc->coeff[1] = tmp >> 16;
 
index 250ceffbd481b26ad5c53a38d5dae1c7af13f589..57438989f4691a7bc9f7d40d6b19e6f03e554eeb 100644 (file)
 #define _PIPE_A_WGC_C21_C20    0x600C0 /* s2.10 */
 #define _PIPE_A_WGC_C22                0x600C4 /* s2.10 */
 
-#define PIPE_WGC_C01_C00(pipe)         _MMIO_TRANS2(dev_priv, pipe, _PIPE_A_WGC_C01_C00)
+#define PIPE_WGC_C01_C00(dev_priv, pipe)               _MMIO_TRANS2(dev_priv, pipe, _PIPE_A_WGC_C01_C00)
 #define PIPE_WGC_C02(pipe)             _MMIO_TRANS2(dev_priv, pipe, _PIPE_A_WGC_C02)
 #define PIPE_WGC_C11_C10(pipe)         _MMIO_TRANS2(dev_priv, pipe, _PIPE_A_WGC_C11_C10)
 #define PIPE_WGC_C12(pipe)             _MMIO_TRANS2(dev_priv, pipe, _PIPE_A_WGC_C12)