ALSA: hda: cs35l41: fix double free on error in probe()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 11 Jan 2022 07:22:32 +0000 (10:22 +0300)
committerTakashi Iwai <tiwai@suse.de>
Tue, 11 Jan 2022 15:57:24 +0000 (16:57 +0100)
If we encounter an error after the kfree(acpi_hw_cfg); then the goto
err; will result in a double free.

Fixes: 7b2f3eb492da ("ALSA: hda: cs35l41: Add support for CS35L41 in HDA systems")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20220111072232.GG11243@kili
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/cs35l41_hda.c

index aa5bb6977792c4268ed0f17425667a21b0256e2b..30b40d865863f0a3c2b54079d70df8e5f38317df 100644 (file)
@@ -477,6 +477,7 @@ int cs35l41_hda_probe(struct device *dev, const char *device_name, int id, int i
        if (ret)
                goto err;
        kfree(acpi_hw_cfg);
+       acpi_hw_cfg = NULL;
 
        if (cs35l41->reg_seq->probe) {
                ret = regmap_register_patch(cs35l41->regmap, cs35l41->reg_seq->probe,