scsi: pm8001: Clean up inconsistent indenting

Eliminate the following smatch warning:

drivers/scsi/pm8001/pm8001_ctl.c:760 pm8001_update_flash() warn:
inconsistent indenting

Link: https://lore.kernel.org/r/20220208025500.29511-1-yang.lee@linux.alibaba.com
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Acked-by: Jack Wang <jinpu.wang@ionos.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/pm8001/pm8001_ctl.c b/drivers/scsi/pm8001/pm8001_ctl.c
index 41a63c9b719bd81d5376696be0826b40cf568c30..66307783c73cb47bcc1e4a7e87b6fcc912063173 100644 (file)
--- a/drivers/scsi/pm8001/pm8001_ctl.c
+++ b/drivers/scsi/pm8001/pm8001_ctl.c
@@ -727,6 +727,8 @@ static int pm8001_update_flash(struct pm8001_hba_info *pm8001_ha)
        u32             sizeRead = 0;
        u32             ret = 0;
        u32             length = 1024 * 16 + sizeof(*payload) - 1;
+       u32             fc_len;
+       u8              *read_buf;
 
        if (pm8001_ha->fw_image->size < 28) {
                pm8001_ha->fw_status = FAIL_FILE_SIZE;
@@ -755,36 +757,35 @@ static int pm8001_update_flash(struct pm8001_hba_info *pm8001_ha)
                        fwControl->retcode = 0;/* OUT */
                        fwControl->offset = loopNumber * IOCTL_BUF_SIZE;/*OUT */
 
-               /* for the last chunk of data in case file size is not even with
-               4k, load only the rest*/
-               if (((loopcount-loopNumber) == 1) &&
-                       ((partitionSize + HEADER_LEN) % IOCTL_BUF_SIZE)) {
-                       fwControl->len =
-                               (partitionSize + HEADER_LEN) % IOCTL_BUF_SIZE;
-                       memcpy((u8 *)fwControl->buffer,
-                               (u8 *)pm8001_ha->fw_image->data + sizeRead,
-                               (partitionSize + HEADER_LEN) % IOCTL_BUF_SIZE);
-                       sizeRead +=
-                               (partitionSize + HEADER_LEN) % IOCTL_BUF_SIZE;
-               } else {
-                       memcpy((u8 *)fwControl->buffer,
-                               (u8 *)pm8001_ha->fw_image->data + sizeRead,
-                               IOCTL_BUF_SIZE);
-                       sizeRead += IOCTL_BUF_SIZE;
-               }
-
-               pm8001_ha->nvmd_completion = &completion;
-               ret = PM8001_CHIP_DISP->fw_flash_update_req(pm8001_ha, payload);
-               if (ret) {
-                       pm8001_ha->fw_status = FAIL_OUT_MEMORY;
-                       goto out;
-               }
-               wait_for_completion(&completion);
-               if (fwControl->retcode > FLASH_UPDATE_IN_PROGRESS) {
-                       pm8001_ha->fw_status = fwControl->retcode;
-                       ret = -EFAULT;
-                       goto out;
-               }
+                       /*
+                        * for the last chunk of data in case file size is
+                        * not even with 4k, load only the rest
+                        */
+
+                       read_buf  = (u8 *)pm8001_ha->fw_image->data + sizeRead;
+                       fc_len = (partitionSize + HEADER_LEN) % IOCTL_BUF_SIZE;
+
+                       if (loopcount - loopNumber == 1 && fc_len) {
+                               fwControl->len = fc_len;
+                               memcpy((u8 *)fwControl->buffer, read_buf, fc_len);
+                               sizeRead += fc_len;
+                       } else {
+                               memcpy((u8 *)fwControl->buffer, read_buf, IOCTL_BUF_SIZE);
+                               sizeRead += IOCTL_BUF_SIZE;
+                       }
+
+                       pm8001_ha->nvmd_completion = &completion;
+                       ret = PM8001_CHIP_DISP->fw_flash_update_req(pm8001_ha, payload);
+                       if (ret) {
+                               pm8001_ha->fw_status = FAIL_OUT_MEMORY;
+                               goto out;
+                       }
+                       wait_for_completion(&completion);
+                       if (fwControl->retcode > FLASH_UPDATE_IN_PROGRESS) {
+                               pm8001_ha->fw_status = fwControl->retcode;
+                               ret = -EFAULT;
+                               goto out;
+                       }
                }
        }
 out: