staging: rtl8723bs: Remove constant result function CheckNegative()

Remove function CheckNegative() that returns always true to shorten code.

Signed-off-by: Philipp Hortmann <philipp.hortmann@emerson.com>
Link: https://lore.kernel.org/r/20240709062634.9454-1-philipp.hortmann@emerson.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/rtl8723bs/hal/HalHWImg8723B_BB.c b/drivers/staging/rtl8723bs/hal/HalHWImg8723B_BB.c
index dd0f74b0cf0da545b5cda8dd4196087624a3c15b..4da2487f6750ed03247348d68aa6aabde5abb685 100644 (file)
--- a/drivers/staging/rtl8723bs/hal/HalHWImg8723B_BB.c
+++ b/drivers/staging/rtl8723bs/hal/HalHWImg8723B_BB.c
@@ -70,13 +70,6 @@ static bool CheckPositive(
        return false;
 }
 
-static bool CheckNegative(
-       struct dm_odm_t *pDM_Odm, const u32  Condition1, const u32 Condition2
-)
-{
-       return true;
-}
-
 /******************************************************************************
 *                           AGC_TAB.TXT
 ******************************************************************************/
@@ -244,10 +237,7 @@ void ODM_ReadAndConfig_MP_8723B_AGC_TAB(struct dm_odm_t *pDM_Odm)
                                READ_NEXT_PAIR(v1, v2, i);
                        } else {
                                READ_NEXT_PAIR(v1, v2, i);
-                               if (!CheckNegative(pDM_Odm, v1, v2))
-                                       bMatched = false;
-                               else
-                                       bMatched = true;
+                               bMatched = true;
                                READ_NEXT_PAIR(v1, v2, i);
                        }
 
@@ -506,10 +496,7 @@ void ODM_ReadAndConfig_MP_8723B_PHY_REG(struct dm_odm_t *pDM_Odm)
                                READ_NEXT_PAIR(v1, v2, i);
                        } else {
                                READ_NEXT_PAIR(v1, v2, i);
-                               if (!CheckNegative(pDM_Odm, v1, v2))
-                                       bMatched = false;
-                               else
-                                       bMatched = true;
+                               bMatched = true;
                                READ_NEXT_PAIR(v1, v2, i);
                        }
 

diff --git a/drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c b/drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c
index 47e66f4ad9d1bcbb5204515e7faaed3301d1abc4..1f0cc8d58df3ea316c546a9cae10c87dbec3bfc2 100644 (file)
--- a/drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c
+++ b/drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c
@@ -68,13 +68,6 @@ static bool CheckPositive(
        return false;
 }
 
-static bool CheckNegative(
-       struct dm_odm_t *pDM_Odm, const u32 Condition1, const u32 Condition2
-)
-{
-       return true;
-}
-
 /******************************************************************************
 *                           MAC_REG.TXT
 ******************************************************************************/
@@ -214,10 +207,7 @@ void ODM_ReadAndConfig_MP_8723B_MAC_REG(struct dm_odm_t *pDM_Odm)
                                READ_NEXT_PAIR(v1, v2, i);
                        } else {
                                READ_NEXT_PAIR(v1, v2, i);
-                               if (!CheckNegative(pDM_Odm, v1, v2))
-                                       bMatched = false;
-                               else
-                                       bMatched = true;
+                               bMatched = true;
                                READ_NEXT_PAIR(v1, v2, i);
                        }
 

diff --git a/drivers/staging/rtl8723bs/hal/HalHWImg8723B_RF.c b/drivers/staging/rtl8723bs/hal/HalHWImg8723B_RF.c
index efc68c17b126ab9713ba7f94ee5e9676473e335a..155ec311a52ea6882467e6955ba1c841bacabc7a 100644 (file)
--- a/drivers/staging/rtl8723bs/hal/HalHWImg8723B_RF.c
+++ b/drivers/staging/rtl8723bs/hal/HalHWImg8723B_RF.c
@@ -78,13 +78,6 @@ static bool CheckPositive(
        return false;
 }
 
-static bool CheckNegative(
-       struct dm_odm_t *pDM_Odm, const u32  Condition1, const u32 Condition2
-)
-{
-       return true;
-}
-
 /******************************************************************************
 *                           RadioA.TXT
 ******************************************************************************/
@@ -245,10 +238,7 @@ void ODM_ReadAndConfig_MP_8723B_RadioA(struct dm_odm_t *pDM_Odm)
                                READ_NEXT_PAIR(v1, v2, i);
                        } else {
                                READ_NEXT_PAIR(v1, v2, i);
-                               if (!CheckNegative(pDM_Odm, v1, v2))
-                                       bMatched = false;
-                               else
-                                       bMatched = true;
+                               bMatched = true;
                                READ_NEXT_PAIR(v1, v2, i);
                        }