PCI: qcom: Fix missing error code in qcom_pcie_probe()
authorDan Carpenter <dan.carpenter@linaro.org>
Mon, 8 Jul 2024 18:05:36 +0000 (13:05 -0500)
committerKrzysztof Wilczyński <kwilczynski@kernel.org>
Wed, 10 Jul 2024 05:38:51 +0000 (05:38 +0000)
Return a negative error code if dev_pm_opp_find_freq_floor() fails;
don't return success.

Fixes: 78b5f6f8855e ("PCI: qcom: Add OPP support to scale performance")
Link: https://lore.kernel.org/linux-pci/20240708180539.1447307-2-dan.carpenter@linaro.org
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Tested-by: Anders Roxell <anders.roxell@linaro.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
drivers/pci/controller/dwc/pcie-qcom.c

index c8cbfb91e1d5ec6176b94fbebb394a5d349e56c7..067ccb9cc6d0e67c83a5bd11ac053fbb0dc233f1 100644 (file)
@@ -1578,7 +1578,8 @@ static int qcom_pcie_probe(struct platform_device *pdev)
        if (!ret) {
                opp = dev_pm_opp_find_freq_floor(dev, &max_freq);
                if (IS_ERR(opp)) {
-                       dev_err_probe(pci->dev, PTR_ERR(opp),
+                       ret = PTR_ERR(opp);
+                       dev_err_probe(pci->dev, ret,
                                      "Unable to find max freq OPP\n");
                        goto err_pm_runtime_put;
                } else {