powerpc: mpic: Use str_enabled_disabled() helper function
authorThorsten Blum <thorsten.blum@linux.dev>
Wed, 19 Feb 2025 11:20:52 +0000 (12:20 +0100)
committerMadhavan Srinivasan <maddy@linux.ibm.com>
Wed, 16 Apr 2025 16:49:01 +0000 (22:19 +0530)
Remove hard-coded strings by using the str_enabled_disabled() helper
function.

Use pr_debug() instead of printk(KERN_DEBUG) to silence a checkpatch
warning.

Reviewed-by: Ricardo B. Marlière <ricardo@marliere.net>
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Signed-off-by: Madhavan Srinivasan <maddy@linux.ibm.com>
Link: https://patch.msgid.link/20250219112053.3352-2-thorsten.blum@linux.dev
arch/powerpc/sysdev/mpic.c

index 4afbab83a2e2f3e1b6ce0cfd3bf4bebf662eafcb..c706a08e9955469464cc0f42c74bdf2d2da2cdc4 100644 (file)
@@ -27,6 +27,7 @@
 #include <linux/spinlock.h>
 #include <linux/pci.h>
 #include <linux/slab.h>
+#include <linux/string_choices.h>
 #include <linux/syscore_ops.h>
 #include <linux/ratelimit.h>
 #include <linux/pgtable.h>
@@ -474,9 +475,9 @@ static void __init mpic_scan_ht_msi(struct mpic *mpic, u8 __iomem *devbase,
                addr = addr | ((u64)readl(base + HT_MSI_ADDR_HI) << 32);
        }
 
-       printk(KERN_DEBUG "mpic:   - HT:%02x.%x %s MSI mapping found @ 0x%llx\n",
-               PCI_SLOT(devfn), PCI_FUNC(devfn),
-               flags & HT_MSI_FLAGS_ENABLE ? "enabled" : "disabled", addr);
+       pr_debug("mpic:   - HT:%02x.%x %s MSI mapping found @ 0x%llx\n",
+                PCI_SLOT(devfn), PCI_FUNC(devfn),
+                str_enabled_disabled(flags & HT_MSI_FLAGS_ENABLE), addr);
 
        if (!(flags & HT_MSI_FLAGS_ENABLE))
                writeb(flags | HT_MSI_FLAGS_ENABLE, base + HT_MSI_FLAGS);