spi: wpcm-fiu: Fix uninitialized res
authorJinjie Ruan <ruanjinjie@huawei.com>
Mon, 26 Aug 2024 13:25:43 +0000 (21:25 +0800)
committerMark Brown <broonie@kernel.org>
Wed, 28 Aug 2024 21:22:23 +0000 (22:22 +0100)
The second platform_get_resource_byname() can not be replaced with
devm_platform_ioremap_resource_byname(), because the intermediate "res"
is used by resource_size() later.

Fixes: 3bf2a5359b0b ("spi: wpcm-fiu: Use devm_platform_ioremap_resource_byname()")
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Link: https://patch.msgid.link/20240826132544.3463616-2-ruanjinjie@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-wpcm-fiu.c

index 47e485fd8f84e6c5acb040537c6681256611228d..05c10b3e65158d48b1b335ce8da940a181f0f3e2 100644 (file)
@@ -458,7 +458,8 @@ static int wpcm_fiu_probe(struct platform_device *pdev)
        if (IS_ERR(fiu->clk))
                return PTR_ERR(fiu->clk);
 
-       fiu->memory = devm_platform_ioremap_resource_byname(pdev, "memory");
+       res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "memory");
+       fiu->memory = devm_ioremap_resource(dev, res);
        fiu->memory_size = min_t(size_t, resource_size(res), MAX_MEMORY_SIZE_TOTAL);
        if (IS_ERR(fiu->memory)) {
                dev_err(dev, "Failed to map flash memory window\n");