drm/amd/display: Remove duplicate 'update_idle_uclk' in dcn401 clk_mgr code
authorIvan Lipski <ivlipski@amd.com>
Mon, 27 May 2024 17:28:44 +0000 (13:28 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 14 Jun 2024 20:17:15 +0000 (16:17 -0400)
[WHY]
The coverity analysis flagged this if expression as it contains a
'CONSTANT_EXPRESSION_RESULT': 'update_idle_uclk' is 'ORd' with itself.

[HOW]
Removed the duplicate 'update_idle_uclk'.

Reviewed-by: Alex Hung <alex.hung@amd.com>
Acked-by: Zaeem Mohamed <zaeem.mohamed@amd.com>
Signed-off-by: Ivan Lipski <ivlipski@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/clk_mgr/dcn401/dcn401_clk_mgr.c

index 0fbe615069f085f7071d5a9b6963a40410c2bd92..28769deaad37307901a59332d15be4a5a960c18b 100644 (file)
@@ -940,7 +940,7 @@ static unsigned int dcn401_build_update_bandwidth_clocks_sequence(
        }
 
        /* CLK_MGR401_UPDATE_IDLE_HARDMINS */
-       if ((update_idle_uclk || update_idle_uclk) && is_idle_dpm_enabled) {
+       if (update_idle_uclk && is_idle_dpm_enabled) {
                block_sequence[num_steps].params.update_idle_hardmin_params.uclk_mhz = idle_uclk_mhz;
                block_sequence[num_steps].params.update_idle_hardmin_params.fclk_mhz = idle_fclk_mhz;
                block_sequence[num_steps].func = CLK_MGR401_UPDATE_IDLE_HARDMINS;