drm/amd/display: Add link rate optimization logs for ILR
authorMichael Strauss <michael.strauss@amd.com>
Tue, 6 Apr 2021 16:20:51 +0000 (12:20 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 21 Apr 2021 01:41:28 +0000 (21:41 -0400)
[Why&How]
Add logs to verify ILR optimization behaviour on boot

Signed-off-by: Michael Strauss <michael.strauss@amd.com>
Reviewed-by: Nicholas Kazlauskas <Nicholas.Kazlauskas@amd.com>
Acked-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/core/dc.c
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c

index 79c652eaddb6a34814e49f65cd0f03bdfd351f6e..4713f09bcbf18f8a39825eb016bdc058048a587a 100644 (file)
@@ -1434,6 +1434,7 @@ bool dc_validate_seamless_boot_timing(const struct dc *dc,
        }
 
        if (is_edp_ilr_optimization_required(link, crtc_timing)) {
+               DC_LOG_EVENT_LINK_TRAINING("Seamless boot disabled to optimize eDP link rate\n");
                return false;
        }
 
index bbf2865b25c50594ca8663e704c75424e35e1179..3ff3d9e9098370a198dbe983c8a6c597441b87d0 100644 (file)
@@ -4739,8 +4739,10 @@ bool is_edp_ilr_optimization_required(struct dc_link *link, struct dc_crtc_timin
        core_link_read_dpcd(link, DP_LINK_BW_SET,
                                &link_bw_set, sizeof(link_bw_set));
 
-       if (link_bw_set)
+       if (link_bw_set) {
+               DC_LOG_EVENT_LINK_TRAINING("eDP ILR: Optimization required, VBIOS used link_bw_set\n");
                return true;
+       }
 
        // Read DPCD 00115h to find the edp link rate set used
        core_link_read_dpcd(link, DP_LINK_RATE_SET,
@@ -4755,9 +4757,12 @@ bool is_edp_ilr_optimization_required(struct dc_link *link, struct dc_crtc_timin
        decide_edp_link_settings(link, &link_setting, req_bw);
 
        if (link->dpcd_caps.edp_supported_link_rates[link_rate_set] != link_setting.link_rate ||
-                       lane_count_set.bits.LANE_COUNT_SET != link_setting.lane_count)
+                       lane_count_set.bits.LANE_COUNT_SET != link_setting.lane_count) {
+               DC_LOG_EVENT_LINK_TRAINING("eDP ILR: Optimization required, VBIOS link_rate_set not optimal\n");
                return true;
+       }
 
+       DC_LOG_EVENT_LINK_TRAINING("eDP ILR: No optimization required, VBIOS set optimal link_rate_set\n");
        return false;
 }
 
index dd903b267ca5c75bca19558b22fb72cb1157e0bb..5ddeee96bf2355de3c946ad211c4cf834de25d58 100644 (file)
@@ -1695,6 +1695,8 @@ void dce110_enable_accelerated_mode(struct dc *dc, struct dc_state *context)
        bool can_apply_edp_fast_boot = false;
        bool can_apply_seamless_boot = false;
        bool keep_edp_vdd_on = false;
+       DC_LOGGER_INIT();
+
 
        get_edp_links_with_sink(dc, edp_links_with_sink, &edp_with_sink_num);
        get_edp_links(dc, edp_links, &edp_num);
@@ -1717,6 +1719,8 @@ void dce110_enable_accelerated_mode(struct dc *dc, struct dc_state *context)
                                        edp_stream = edp_streams[0];
                                        can_apply_edp_fast_boot = !is_edp_ilr_optimization_required(edp_stream->link, &edp_stream->timing);
                                        edp_stream->apply_edp_fast_boot_optimization = can_apply_edp_fast_boot;
+                                       if (can_apply_edp_fast_boot)
+                                               DC_LOG_EVENT_LINK_TRAINING("eDP fast boot disabled to optimize link rate\n");
 
                                        break;
                                }