staging: rtl8723bs: Initialize variables at declaration in rtl8723bs_xmit.c

Make the code more readable by moving trivial
initializations up with the declarations instead
of wasting a line on that.

Signed-off-by: Erick Karanja <karanja99erick@gmail.com>
Link: https://lore.kernel.org/r/0a2165d8135d2b4de6b9c05fdc56fe5d7408e7c8.1744268316.git.karanja99erick@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
index 5dc1c12fe03e5727c325b779b159d616871e1f02..842e19b534217ab72171bddf7d90935d85e251ba 100644 (file)
--- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
@@ -120,13 +120,10 @@ free_xmitbuf:
  */
 s32 rtl8723bs_xmit_buf_handler(struct adapter *padapter)
 {
-       struct xmit_priv *pxmitpriv;
+       struct xmit_priv *pxmitpriv = &padapter->xmitpriv;
        u8 queue_empty, queue_pending;
        s32 ret;
 
-
-       pxmitpriv = &padapter->xmitpriv;
-
        if (wait_for_completion_interruptible(&pxmitpriv->xmit_comp)) {
                netdev_emerg(padapter->pnetdev,
                             "%s: down SdioXmitBufSema fail!\n", __func__);
@@ -357,12 +354,9 @@ static s32 xmit_xmitframes(struct adapter *padapter, struct xmit_priv *pxmitpriv
  */
 static s32 rtl8723bs_xmit_handler(struct adapter *padapter)
 {
-       struct xmit_priv *pxmitpriv;
+       struct xmit_priv *pxmitpriv = &padapter->xmitpriv;
        s32 ret;
 
-
-       pxmitpriv = &padapter->xmitpriv;
-
        if (wait_for_completion_interruptible(&pxmitpriv->SdioXmitStart)) {
                netdev_emerg(padapter->pnetdev, "%s: SdioXmitStart fail!\n",
                             __func__);
@@ -408,13 +402,9 @@ next:
 
 int rtl8723bs_xmit_thread(void *context)
 {
-       s32 ret;
-       struct adapter *padapter;
-       struct xmit_priv *pxmitpriv;
-
-       ret = _SUCCESS;
-       padapter = context;
-       pxmitpriv = &padapter->xmitpriv;
+       s32 ret = _SUCCESS;
+       struct adapter *padapter = context;
+       struct xmit_priv *pxmitpriv = &padapter->xmitpriv;
 
        allow_signal(SIGTERM);
 
@@ -435,16 +425,13 @@ s32 rtl8723bs_mgnt_xmit(
 )
 {
        s32 ret = _SUCCESS;
-       struct pkt_attrib *pattrib;
-       struct xmit_buf *pxmitbuf;
+       struct pkt_attrib *pattrib = &pmgntframe->attrib;
+       struct xmit_buf *pxmitbuf = pmgntframe->pxmitbuf;
        struct xmit_priv *pxmitpriv = &padapter->xmitpriv;
        struct dvobj_priv *pdvobjpriv = adapter_to_dvobj(padapter);
        u8 *pframe = (u8 *)(pmgntframe->buf_addr) + TXDESC_OFFSET;
        u8 txdesc_size = TXDESC_SIZE;
 
-       pattrib = &pmgntframe->attrib;
-       pxmitbuf = pmgntframe->pxmitbuf;
-
        rtl8723b_update_txdesc(pmgntframe, pmgntframe->buf_addr);
 
        pxmitbuf->len = txdesc_size + pattrib->last_txcmdsz;
@@ -557,15 +544,13 @@ s32 rtl8723bs_init_xmit_priv(struct adapter *padapter)
 
 void rtl8723bs_free_xmit_priv(struct adapter *padapter)
 {
-       struct xmit_priv *pxmitpriv;
+       struct xmit_priv *pxmitpriv = &padapter->xmitpriv;
        struct xmit_buf *pxmitbuf;
-       struct __queue *pqueue;
+       struct __queue *pqueue = &pxmitpriv->pending_xmitbuf_queue;
        struct list_head *plist, *phead;
        struct list_head tmplist;
 
 
-       pxmitpriv = &padapter->xmitpriv;
-       pqueue = &pxmitpriv->pending_xmitbuf_queue;
        phead = get_list_head(pqueue);
        INIT_LIST_HEAD(&tmplist);