net: txgbe: fix to clear interrupt status after handling IRQ

GPIO EOI is not set to clear interrupt status after handling the
interrupt. It should be done in irq_chip->irq_ack, but this function
is not called in handle_nested_irq(). So executing function
txgbe_gpio_irq_ack() manually in txgbe_gpio_irq_handler().

Fixes: aefd013624a1 ("net: txgbe: use irq_domain for interrupt controller")
Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
Link: https://lore.kernel.org/r/20240301092956.18544-2-jiawenwu@trustnetic.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>

diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c b/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c
index c112f79b026e7836bd6fbeaf51e00173f37292c2..93295916b1d2b80751637dee4a0006688958c428 100644 (file)
--- a/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c
+++ b/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c
@@ -475,8 +475,10 @@ irqreturn_t txgbe_gpio_irq_handler(int irq, void *data)
        gc = txgbe->gpio;
        for_each_set_bit(hwirq, &gpioirq, gc->ngpio) {
                int gpio = irq_find_mapping(gc->irq.domain, hwirq);
+               struct irq_data *d = irq_get_irq_data(gpio);
                u32 irq_type = irq_get_trigger_type(gpio);
 
+               txgbe_gpio_irq_ack(d);
                handle_nested_irq(gpio);
 
                if ((irq_type & IRQ_TYPE_SENSE_MASK) == IRQ_TYPE_EDGE_BOTH) {