coresight: Don't initialize variables unnecessarily
authorStephen Boyd <swboyd@chromium.org>
Mon, 18 May 2020 18:02:36 +0000 (12:02 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 19 May 2020 14:31:17 +0000 (16:31 +0200)
These variables are assigned again before they're used. Leave them
unassigned at first so that the compiler can detect problems in the
future with use before initialization.

Cc: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: Mike Leach <mike.leach@linaro.org>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Link: https://lore.kernel.org/r/20200518180242.7916-18-mathieu.poirier@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/hwtracing/coresight/coresight-cti-sysfs.c

index a095db03d2bc1199fd038d55d6a17e9a89fcce5e..aeea39cbd161dd0b9a3634e47be61a7ffba94e4b 100644 (file)
@@ -1036,8 +1036,8 @@ static int cti_create_con_sysfs_attr(struct device *dev,
                                     enum cti_conn_attr_type attr_type,
                                     int attr_idx)
 {
-       struct dev_ext_attribute *eattr = 0;
-       char *name = 0;
+       struct dev_ext_attribute *eattr;
+       char *name;
 
        eattr = devm_kzalloc(dev, sizeof(struct dev_ext_attribute),
                                    GFP_KERNEL);
@@ -1156,8 +1156,8 @@ static int cti_create_cons_groups(struct device *dev, struct cti_device *ctidev)
 int cti_create_cons_sysfs(struct device *dev, struct cti_drvdata *drvdata)
 {
        struct cti_device *ctidev = &drvdata->ctidev;
-       int err = 0, con_idx = 0, i;
-       struct cti_trig_con *tc = NULL;
+       int err, con_idx = 0, i;
+       struct cti_trig_con *tc;
 
        err = cti_create_cons_groups(dev, ctidev);
        if (err)