drm/amdgpu: Clean up error handling in amdgpu_userq_fence_driver_alloc()

1) Checkpatch complains if we print an error message for kzalloc()
   failure.  The kzalloc() failure already has it's own error messages
   built in.  Also this allocation is small enough that it is guaranteed
   to succeed.
2) Return directly instead of doing a goto free_fence_drv.  The
   "fence_drv" is already NULL so no cleanup is necessary.

Reviewed-by: Arvind Yadav <arvind.yadav@amd.com>
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c
index e2e0bd6ae807e9e7f171b18a99aa34dae9ccb4ed..0a3032e01c3429af1ab5b07e1dc801cfd239fa57 100644 (file)
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c
@@ -75,11 +75,8 @@ int amdgpu_userq_fence_driver_alloc(struct amdgpu_device *adev,
        int r;
 
        fence_drv = kzalloc(sizeof(*fence_drv), GFP_KERNEL);
-       if (!fence_drv) {
-               DRM_ERROR("Failed to allocate memory for fence driver\n");
-               r = -ENOMEM;
-               goto free_fence_drv;
-       }
+       if (!fence_drv)
+               return -ENOMEM;
 
        /* Acquire seq64 memory */
        r = amdgpu_seq64_alloc(adev, &fence_drv->va, &fence_drv->gpu_addr,