iio: light: bh1780: assign a static name
authorLinus Walleij <linus.walleij@linaro.org>
Wed, 25 May 2016 07:40:27 +0000 (09:40 +0200)
committerJonathan Cameron <jic23@kernel.org>
Sun, 29 May 2016 18:51:29 +0000 (19:51 +0100)
Using the struct i2c_device->id field for naming the light sensor
is a bad idea: when booting from the pure device tree this is NULL
and that causes the device not to have the "name" property in
sysfs and that in turn confuses the "lsiio" command to stop listing
devices.

So instead of using the device .id, use the hard string "bh1780",
which works just fine.

Fixes: 1f0477f18306 ("iio: light: new driver for the ROHM BH1780")
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
drivers/iio/light/bh1780.c

index 5fd432df2c8f011dcc6a599a3af11f12ce6bd9e0..b54dcba05a8294d988d6bf5421cca21f01224159 100644 (file)
@@ -187,7 +187,7 @@ static int bh1780_probe(struct i2c_client *client,
 
        indio_dev->dev.parent = &client->dev;
        indio_dev->info = &bh1780_info;
-       indio_dev->name = id->name;
+       indio_dev->name = "bh1780";
        indio_dev->channels = bh1780_channels;
        indio_dev->num_channels = ARRAY_SIZE(bh1780_channels);
        indio_dev->modes = INDIO_DIRECT_MODE;