iio: imu: st_lsm6dsx: Switch to sparse friendly iio_device_claim/release_direct()
authorJonathan Cameron <Jonathan.Cameron@huawei.com>
Mon, 31 Mar 2025 12:13:00 +0000 (13:13 +0100)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Tue, 22 Apr 2025 18:10:00 +0000 (19:10 +0100)
These new functions allow sparse to find failures to release
direct mode reducing chances of bugs over the claim_direct_mode()
functions that are deprecated.

Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>
Reviewed-by: David Lechner <dlechner@baylibre.com>
Reviewed-by: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
Link: https://patch.msgid.link/20250331121317.1694135-21-jic23@kernel.org
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c

index 17a74f5adfc04dead51b719d63a1c5c7f65e4918..3c5e65dc0f971f4dad8d1156f6de9fd6be3fc0b6 100644 (file)
@@ -558,12 +558,11 @@ st_lsm6dsx_shub_read_raw(struct iio_dev *iio_dev,
 
        switch (mask) {
        case IIO_CHAN_INFO_RAW:
-               ret = iio_device_claim_direct_mode(iio_dev);
-               if (ret)
-                       break;
+               if (!iio_device_claim_direct(iio_dev))
+                       return -EBUSY;
 
                ret = st_lsm6dsx_shub_read_oneshot(sensor, ch, val);
-               iio_device_release_direct_mode(iio_dev);
+               iio_device_release_direct(iio_dev);
                break;
        case IIO_CHAN_INFO_SAMP_FREQ:
                *val = sensor->ext_info.slv_odr / 1000;
@@ -657,13 +656,12 @@ st_lsm6dsx_shub_write_raw(struct iio_dev *iio_dev,
 {
        int ret;
 
-       ret = iio_device_claim_direct_mode(iio_dev);
-       if (ret)
-               return ret;
+       if (!iio_device_claim_direct(iio_dev))
+               return -EBUSY;
 
        ret = __st_lsm6dsx_shub_write_raw(iio_dev, chan, val, val2, mask);
 
-       iio_device_release_direct_mode(iio_dev);
+       iio_device_release_direct(iio_dev);
 
        return ret;
 }